[GitHub] [pinot] kirkrodrigues commented on a diff in pull request #9942: [feature] Add pinot-clp-log plugin to encode user-specified fields with CLP during ingestion

[GitBox <gi...@apache.org>]

kirkrodrigues commented on code in PR #9942:
URL: https://github.com/apache/pinot/pull/9942#discussion_r1051272869


##########
pinot-distribution/pinot-assembly.xml:
##########
@@ -146,6 +146,12 @@
       </source>
       <destName>plugins/pinot-input-format/pinot-avro/pinot-avro-${project.version}-shaded.jar</destName>
     </file>
+    <file>
+      <source>
+        ${pinot.root}/pinot-plugins/pinot-input-format/pinot-clp-log/target/pinot-clp-log-${project.version}-shaded.jar

Review Comment:
   No, I'm not seeing a version conflict, but aren't all plugins shaded? If you're asking why I had shading in the plugin's pom.xml, that was an error (thanks for catching it).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org