You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/11/21 10:55:17 UTC

[PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

jackwener opened a new pull request, #27363:
URL: https://github.com/apache/doris/pull/27363

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1822721194

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1821132945

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.03 seconds
    stream load tsv:          578 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17099616652 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820871378

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.48 seconds
    stream load tsv:          577 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          64 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.5 seconds inserted 10000000 Rows, about 350K ops/s
    storage size: 17101502368 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820907157

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820857459

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 66e6bff6d79370adc44801e9e93e8a442980741f, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4945	4648	4649	4648
   q2	354	151	159	151
   q3	2019	1919	1932	1919
   q4	1378	1245	1239	1239
   q5	3947	3969	4040	3969
   q6	245	127	130	127
   q7	1428	900	877	877
   q8	2746	2774	2763	2763
   q9	9720	9722	9577	9577
   q10	3459	3519	3528	3519
   q11	373	246	242	242
   q12	449	297	297	297
   q13	4562	3820	3821	3820
   q14	319	299	278	278
   q15	590	536	532	532
   q16	663	587	596	587
   q17	1141	960	922	922
   q18	7825	7204	7349	7204
   q19	1671	1659	1679	1659
   q20	551	318	316	316
   q21	4392	3951	3975	3951
   q22	481	372	372	372
   Total cold run time: 53258 ms
   Total hot run time: 48969 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4627	4613	4579	4579
   q2	343	236	252	236
   q3	4012	3991	3989	3989
   q4	2713	2688	2711	2688
   q5	9793	9815	9754	9754
   q6	245	125	128	125
   q7	3030	2506	2473	2473
   q8	4426	4441	4500	4441
   q9	13218	13168	13113	13113
   q10	4108	4196	4198	4196
   q11	808	663	666	663
   q12	983	820	825	820
   q13	4312	3599	3563	3563
   q14	388	356	365	356
   q15	581	518	529	518
   q16	743	664	665	664
   q17	3857	3860	3912	3860
   q18	9459	8950	9015	8950
   q19	1773	1773	1758	1758
   q20	2384	2075	2059	2059
   q21	8918	8545	8928	8545
   q22	904	778	760	760
   Total cold run time: 81625 ms
   Total hot run time: 78110 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1822721114

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820822472

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820875198

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.44 seconds
    stream load tsv:          576 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17097919748 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #27363:
URL: https://github.com/apache/doris/pull/27363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820782964

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1820691822

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [performance](Planner): optimize getStringValue() in DateLiteral [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27363:
URL: https://github.com/apache/doris/pull/27363#issuecomment-1821109314

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit d56bd17c358a10fa54b624f155540bd71f73f500, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4886	4666	4670	4666
   q2	371	145	174	145
   q3	2037	1928	1834	1834
   q4	1379	1265	1248	1248
   q5	3973	3960	3978	3960
   q6	242	131	132	131
   q7	1423	868	879	868
   q8	2750	2772	2753	2753
   q9	9767	9598	9577	9577
   q10	3449	3543	3542	3542
   q11	384	245	242	242
   q12	432	287	287	287
   q13	4575	3786	3819	3786
   q14	325	280	289	280
   q15	582	547	530	530
   q16	661	585	587	585
   q17	1137	940	965	940
   q18	7790	7453	7350	7350
   q19	1650	1668	1644	1644
   q20	526	290	304	290
   q21	4370	3946	3940	3940
   q22	476	389	371	371
   Total cold run time: 53185 ms
   Total hot run time: 48969 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4591	4571	4538	4538
   q2	339	225	278	225
   q3	4001	3992	3996	3992
   q4	2686	2682	2744	2682
   q5	9697	9726	9721	9721
   q6	238	122	124	122
   q7	3006	2463	2491	2463
   q8	4421	4493	4494	4493
   q9	13214	13171	13142	13142
   q10	4120	4194	4191	4191
   q11	821	643	673	643
   q12	980	815	796	796
   q13	4272	3567	3519	3519
   q14	381	354	342	342
   q15	581	533	523	523
   q16	740	685	673	673
   q17	3926	3918	3948	3918
   q18	9542	9057	9056	9056
   q19	1809	1758	1766	1758
   q20	2384	2081	2050	2050
   q21	8694	8451	8617	8451
   q22	888	818	807	807
   Total cold run time: 81331 ms
   Total hot run time: 78105 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org