[GitHub] [hudi] sandyfog commented on a diff in pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey

["sandyfog (via GitHub)" <gi...@apache.org>]

sandyfog commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1103599741


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -153,10 +159,10 @@ public String getRecordKey(RowData rowData) {
       // for e.g, fileId + auto inc integer
       return EMPTY_RECORDKEY_PLACEHOLDER;
     } else if (this.simpleRecordKey) {
-      return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0]);
+      return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0],consistentLogicalTimestampEnabled);
     } else {
       Object[] keyValues = this.recordKeyProjection.projectAsValues(rowData);
-      return getRecordKey(keyValues, this.recordKeyFields);
+      return getRecordKey(keyValues, this.recordKeyFields,consistentLogicalTimestampEnabled);
     }

Review Comment:
   Thanks！



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org