You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/16 06:24:34 UTC
[GitHub] [echarts] pissang opened a new pull request #15735: feat(type): provide ability to extend series option
pissang opened a new pull request #15735:
URL: https://github.com/apache/echarts/pull/15735
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
Previously we can't use TypeScript declaration merging feature to extend our `SeriesOption` in the extensions like echarts-wordcloud because it's a union type.
This PR adds an interface `RegisteredSeriesOption`. It can be extended with new types of series. `SeriesOption` will pick all its values and get a union type.
```ts
import echarts from 'echarts';
declare module 'echarts/types/dist/echarts' {
interface RegisteredSeriesOption {
wordCloud: WordCloudSeriesOption
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15735: feat(type): provide ability to extend series option
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15735:
URL: https://github.com/apache/echarts/pull/15735#issuecomment-920613707
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #15735: feat(type): provide ability to extend series option
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15735:
URL: https://github.com/apache/echarts/pull/15735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15735: feat(type): provide ability to extend series option
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15735:
URL: https://github.com/apache/echarts/pull/15735#issuecomment-920615855
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org