You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/08/01 05:53:32 UTC

[kudu-CR] [common] Remove std::lock guard template parameter

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 )

Change subject: [common] Remove std::lock_guard template parameter
......................................................................


Patch Set 4:

> (1 comment)
 > 
 > > Patch Set 3:
 > >
 > > (1 comment)
 > >
 > > > Build Failed
 > >  >
 > >  > http://jenkins.kudu.apache.org/job/pre_commit/359/ : FAILURE
 > >
 > > IWYU isn't happy: https://jenkins.kudu.apache.org/job/build_and_test/2146/console
 > >
 > > Those errors mostly about unneeded <mutex> header once this patch
 > is in.
 > 
 > Fixed the IWYU errors.

It seems IWYU isn't yet happy: https://jenkins.kudu.apache.org/job/build_and_test/2156/console


-- 
To view, visit http://gerrit.cloudera.org:8080/21623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ef039ec62b4aac55c13c611eb9999fae56eeeb8
Gerrit-Change-Number: 21623
Gerrit-PatchSet: 4
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 05:53:32 +0000
Gerrit-HasComments: No