[GitHub] [ozone] dombizita commented on a diff in pull request #3952: HDDS-7468. Recon: clusterState API Changes for adding missingContainerCount

[GitBox <gi...@apache.org>]

dombizita commented on code in PR #3952:
URL: https://github.com/apache/ozone/pull/3952#discussion_r1022143176


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystemWithFSO.java:
##########
@@ -180,7 +180,7 @@ public void testRenameDirToItsOwnSubDir() throws Exception {
   }
 
   @Override
-  @Test

Review Comment:
   Is this intended? Seems unrelated to me, but if not, why do you need to ingore this test?



##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -55,21 +58,27 @@ public class ClusterStateEndpoint {
 
   private static final Logger LOG =
       LoggerFactory.getLogger(ClusterStateEndpoint.class);
+  public static final int LIMIT = 1001;

Review Comment:
   Couldn't we use 1000 as a limit? I also found [this](https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconConstants.java#L47) inside ReconConstants. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org