You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/26 11:40:14 UTC
[PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
pjfanning opened a new pull request, #1150:
URL: https://github.com/apache/incubator-pekko/pull/1150
cherry pick 1e41829bf7abeec268b9a409f35051ed7f4e0090 #1128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1150:
URL: https://github.com/apache/incubator-pekko/pull/1150#issuecomment-1964045082
We can always decide to backport this later if someone brings it up but its always been the intention that the 1.0.x is just a step up to the 1.1.x branch which contains all the improvements/fixes etc etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1150:
URL: https://github.com/apache/incubator-pekko/pull/1150#issuecomment-1963987347
Im also on the fence on this one, people may be relying on this behaviour even though its "wrong" and I am not sure I would categorize this as critical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1150:
URL: https://github.com/apache/incubator-pekko/pull/1150#issuecomment-1964025218
Ok. I'll close this. I think this could be classified as a bug because it affects TLS v1.3 users but since we are getting close to a 1.1 milestone, maybe, we can delay the fix to 1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #1150:
URL: https://github.com/apache/incubator-pekko/pull/1150#issuecomment-1963994311
> Im also on the fence on this one, people may be relying on this behaviour even though its "wrong"
(that risk seems relatively low to me)
> and I am not sure I would categorize this as critical
agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #1150: in TlsActor flush data to user only after handshake has finished (#1128)
URL: https://github.com/apache/incubator-pekko/pull/1150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] in TlsActor flush data to user only after handshake has finished (#1128) [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1150:
URL: https://github.com/apache/incubator-pekko/pull/1150#issuecomment-1964021742
> (that risk seems relatively low to me)
Oh I agree its quite low, but the whole point of the 1.0.x branch is to keep the behaviour as close as possible to original Akka 2.6.x to minimize surprises when people migrate (hence why no changes unless its security or critical)
@pjfanning wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org