You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Rene Scheibe (JIRA)" <ji...@apache.org> on 2011/01/20 09:37:43 UTC

[jira] Created: (OFBIZ-4128) Invalid duplicate code in ShipmentServices

Invalid duplicate code in ShipmentServices
------------------------------------------

                 Key: OFBIZ-4128
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4128
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Rene Scheibe
            Priority: Minor


Looks like ShipmentServices contains some invalid duplicate code that doesn't perform a null check.

I think it can just be removed as the correct code is located right below it.

Please double check.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-4128) Invalid duplicate code in ShipmentServices

Posted by "Rene Scheibe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rene Scheibe updated OFBIZ-4128:
--------------------------------

    Attachment: OFBIZ-4128_ShipmentServices.patch

patch for removing the invalid code

> Invalid duplicate code in ShipmentServices
> ------------------------------------------
>
>                 Key: OFBIZ-4128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4128
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Rene Scheibe
>            Priority: Minor
>         Attachments: OFBIZ-4128_ShipmentServices.patch
>
>
> Looks like ShipmentServices contains some invalid duplicate code that doesn't perform a null check.
> I think it can just be removed as the correct code is located right below it.
> Please double check.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-4128) Invalid duplicate code in ShipmentServices

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4128.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

Thanks René,

Your patch is in trunk at r1061167, R10.04 at r1061173, R9.04 at r1061174  


> Invalid duplicate code in ShipmentServices
> ------------------------------------------
>
>                 Key: OFBIZ-4128
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4128
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Rene Scheibe
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4128_ShipmentServices.patch
>
>
> Looks like ShipmentServices contains some invalid duplicate code that doesn't perform a null check.
> I think it can just be removed as the correct code is located right below it.
> Please double check.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.