You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 12:27:26 UTC
[GitHub] [arrow-datafusion] milenkovicm opened a new issue, #4142: `TableProviderFactory::create` should have `Optional` parameter
milenkovicm opened a new issue, #4142:
URL: https://github.com/apache/arrow-datafusion/issues/4142
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
`datafusion::datasource::datasource::TableProviderFactory::create` should have `Optional<DFSchemaRef>` a parameter to support statements with table DDL e.g: `CREATE EXTERNAL TABLE demo_table (c1 integer, c2 integer) STORED AS ...` ?
**Describe the solution you'd like**
add `schema: Optional<DFSchemaRef>` to method signature
**Describe alternatives you've considered**
use `schema: DFSchemaRef` as parameter, which can be empty. I've believe version with Optional make more sense, as it is easier to understand.
**Additional context**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #4142: `TableProviderFactory::create` should have `Optional` parameter
Posted by GitBox <gi...@apache.org>.
alamb closed issue #4142: `TableProviderFactory::create` should have `Optional<DFSchemaRef>` parameter
URL: https://github.com/apache/arrow-datafusion/issues/4142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org