You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/01 14:07:07 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
lhotari opened a new pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118
Fixes #10117
### Motivation & Modifications
SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer is one of the most flaky tests.
The main goal of the changes in this PR is to increase the receive timeouts in the testRedeliveryFailOverConsumer . When looking at the test class, the receive timeouts weren't consistent and this PR improves the test class by using constants for receive timeouts. There's now `RECEIVE_TIMEOUT_SECONDS`, `RECEIVE_TIMEOUT_SHORT_MILLIS` and `RECEIVE_TIMEOUT_MEDIUM_MILLIS` constants to be used for 3 different type of use cases of consumer.receive .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812499941
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812337858
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812912363
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812999054
We have flaky tests that are too annoying.
We should disable them asap.
I am going to send a PR tomorrow if no one else does it.
I started a discussion on the dev ML
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812984020
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812136634
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812296508
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-813808798
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812805042
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812615104
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812952339
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#discussion_r607210526
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java
##########
@@ -1124,7 +1127,7 @@ public void testDeactivatingBacklogConsumer(boolean ackReceiptEnabled) throws Ex
assertTrue(activeSubscriber.contains(sub2));
}
- @Test(timeOut = 2000)
+ @Test(timeOut = 5000)
Review comment:
I'd say to remove these ad-hoc timeouts and just rely on the default 300 seconds timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812846391
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812888763
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812441913
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812695319
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812822607
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812877031
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-813000389
Please check out my email on dev@
The idea is to disable the 4 offending tests and create blocker issues for the release.
There are already tentative PR for fixes but currently the whole PR merge pipeline is stuck.
This patch is one of those but we cannot merge it is CI does not pass.
If you have a better idea please chime in in discussion on the ML.
I would like to merge this patch and other fixes to flaky tests asap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #10118:
URL: https://github.com/apache/pulsar/pull/10118#issuecomment-812999863
If you disable it, no one will watch these unit tests anymore, and the coverage of this part will gone. Really annoying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org