You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/12/18 19:49:49 UTC

[GitHub] [cassandra-dtest] dcapwell commented on a change in pull request #109: CASSANDRA-16332 - Change upgrade cql 2i test to accept static results coming back

dcapwell commented on a change in pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109#discussion_r546057894



##########
File path: upgrade_tests/cql_tests.py
##########
@@ -4122,6 +4122,7 @@ def test_static_columns_with_2i(self):
 
         cursor.execute("CREATE INDEX ON test(v)")
 
+        from_ver = float(self.UPGRADE_PATH.starting_meta.family)

Review comment:
       can't family contain stuff like `x`?  should we use LooseVersion like we do in other tests?
   
   checking...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org