You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafodion.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/01 04:09:04 UTC
[jira] [Commented] (TRAFODION-1502) Trafodion Java files should be
built with Maven and conform to source directory conventions
[ https://issues.apache.org/jira/browse/TRAFODION-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939176#comment-14939176 ]
ASF GitHub Bot commented on TRAFODION-1502:
-------------------------------------------
GitHub user zellerh opened a pull request:
https://github.com/apache/incubator-trafodion/pull/98
TRAFODION-1502 Build remaining Java files in SQL executor and ustat through Maven
Most of the Trafodion Java source files are built through Maven, using
projects DCS, REST, HBase-trx and SQL. A few files remain in the
core/sql/executor and core/sql/ustat directories that are built
through javac commands in the Makefile and helper files. Also, these
files don't conform to common naming standards and therefore are a bit
harder to debug with tools like Eclipse.
This change does the following:
1. Move these remaining Java source files under core/sql/src,
where the UDR-related files already are.
2. Include the class files in trafodion-sql-1.2.0.jar, the
deliverable of the core/sql Maven project.
3. Change the package name to org.trafodion.sql for all these files.
4. Remove the trafodion-HBaseAccess-1.2.0.jar file (content
will be included in trafodion-sql-1.2.0.jar). This jar file
used to be built with a Makefile.
5. Make some source code changes to reflect the new package names
and to avoid calling private method of class
org.apache.hadoop.hive.ql.io.orc.OrcStruct.
6. Remove Makefile rules for compiling Java files.
Also, this change includes a change of the component name for the
event logger. We use SQL.COMP now, to make analyzing log messages
for Trafodion easier. Venkat asked for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zellerh/incubator-trafodion bug/1129
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit a44823fe2fd3991bc13434f73692a70b661efd43
Author: Hans Zeller <ha...@esgyn.com>
Date: 2015-10-01T02:01:45Z
Most of the Trafodion Java source files are built through Maven, using
projects DCS, REST, HBase-trx and SQL. A few files remain in the
core/sql/executor and core/sql/ustat directories that are built
through javac commands in the Makefile and helper files. Also, these
files don't conform to common naming standards and therefore are a bit
harder to debug with tools like Eclipse.
I would like to do the following:
1. Move these remaining Java source files under core/sql/src,
where the UDR-related files already are.
2. Include the class files in trafodion-sql-1.2.0.jar, the
deliverable of the core/sql Maven project.
3. Change the package name to org.trafodion.sql for all these files.
4. Remove the trafodion-HBaseAccess-1.2.0.jar file (content
will be included in trafodion-sql-1.2.0.jar). This jar file
used to be built with a Makefile.
5. Make some source code changes to reflect the new package names
and to avoid calling private method of class
org.apache.hadoop.hive.ql.io.orc.OrcStruct.
6. Remove Makefile rules for compiling Java files.
Also, this change includes a change of the component name for the
event logger. We use SQL.COMP now, to make analyzing log messages
for Trafodion easier. Venkat asked for this change.
----
> Trafodion Java files should be built with Maven and conform to source directory conventions
> -------------------------------------------------------------------------------------------
>
> Key: TRAFODION-1502
> URL: https://issues.apache.org/jira/browse/TRAFODION-1502
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
> Affects Versions: 1.1 (pre-incubation)
> Environment: All
> Reporter: Hans Zeller
> Assignee: Hans Zeller
> Labels: build, maven
> Fix For: 1.2-incubating
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Most of the Trafodion Java source files are built through Maven, using projects DCS, REST, HBase-trx and SQL. A few files remain in the core/sql/executor and core/sql/ustat directories that are built through javac commands in the Makefile and helper files. Also, these files don't conform to common naming standards and therefore are a bit harder to debug with tools like Eclipse.
> I would like to do the following:
> 1. Move these remaining Java source files under core/sql/src, where the UDR-related files already are.
> 2. Include the class files in trafodion-sql-1.2.0.jar, the deliverable of the core/sql Maven project.
> 3. Change the package name to org.trafodion.sql for all these files.
> 4. Remove the trafodion-HBaseAccess-1.2.0.jar file (content will be included in trafodion-sql-1.2.0.jar). This jar file used to be built with a Makefile.
> 5. Make some source code changes to reflect the new package names and to avoid calling private method of class org.apache.hadoop.hive.ql.io.orc.OrcStruct.
> 6. Remove Makefile rules for compiling Java files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)