You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2012/10/16 01:28:29 UTC

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

danielsh@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700:
> http://subversion.tigris.org/issues/show_bug.cgi?id=4246
> 
> In short, hotcopy fails because r1's revprops have been packed.

If anyone wonders how I found this: I read r1358721:1358725, noticed
that upgrade/pack/recover were mentioned, and tested 'verify' and
'hotcopy' - as other operations that take a const char *fs_path, rather
than an svn_fs_t *fs.

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Tue, Oct 16, 2012 at 3:21 AM, Daniel Shahaf <da...@apache.org> wrote:

> On Tue, Oct 16, 2012 at 03:16:23AM +0200, Stefan Fuhrmann wrote:
> > On Tue, Oct 16, 2012 at 1:28 AM, Daniel Shahaf <d.s@daniel.shahaf.name
> >wrote:
> >
> > > danielsh@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700:
> > > > http://subversion.tigris.org/issues/show_bug.cgi?id=4246
> > > >
> > > > In short, hotcopy fails because r1's revprops have been packed.
> > >
> > > If anyone wonders how I found this: I read r1358721:1358725, noticed
> > > that upgrade/pack/recover were mentioned, and tested 'verify' and
> > > 'hotcopy' - as other operations that take a const char *fs_path, rather
> > > than an svn_fs_t *fs.
> > >
> >
> > Oops. Thanks for noticing! Should be fixed now.
> >
>
> The original problem is fixed yes, but another problem remains: if I pass
> --pre-1.4-compatible in the first step, I get SIGFPE:
>
> svn-qavm,0:/tmp/danielsh% $svnadmin hotcopy r r2
> zsh: floating point exception  $svnadmin hotcopy r r2
> svn-qavm,0:/tmp/danielsh% echo $?
> 136
>

Took me some while to track down the various
places where this went wrong. r1404667 and
r1404675 should fix pre-1.4 format issues. I'll try
with 1.2 and 1.1 format to be sure they all work.

-- Stefan^2.

-- 
Certified & Supported Apache Subversion Downloads:
*

http://www.wandisco.com/subversion/download
*

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

Posted by Daniel Shahaf <da...@apache.org>.
On Tue, Oct 16, 2012 at 03:16:23AM +0200, Stefan Fuhrmann wrote:
> On Tue, Oct 16, 2012 at 1:28 AM, Daniel Shahaf <d....@daniel.shahaf.name>wrote:
> 
> > danielsh@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700:
> > > http://subversion.tigris.org/issues/show_bug.cgi?id=4246
> > >
> > > In short, hotcopy fails because r1's revprops have been packed.
> >
> > If anyone wonders how I found this: I read r1358721:1358725, noticed
> > that upgrade/pack/recover were mentioned, and tested 'verify' and
> > 'hotcopy' - as other operations that take a const char *fs_path, rather
> > than an svn_fs_t *fs.
> >
> 
> Oops. Thanks for noticing! Should be fixed now.
> 

The original problem is fixed yes, but another problem remains: if I pass
--pre-1.4-compatible in the first step, I get SIGFPE:

svn-qavm,0:/tmp/danielsh% $svnadmin hotcopy r r2
zsh: floating point exception  $svnadmin hotcopy r r2
svn-qavm,0:/tmp/danielsh% echo $?
136

Thanks!

Daniel

> -- Stefan^2.
> 
> -- 
> *
> 
> Join us this October at Subversion Live
> 2012<http://www.wandisco.com/svn-live-2012>
>  for two days of best practice SVN training, networking, live demos,
> committer meet and greet, and more! Space is limited, so get signed up
> today<http://www.wandisco.com/svn-live-2012>
> !
> *

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Tue, Oct 16, 2012 at 1:28 AM, Daniel Shahaf <d....@daniel.shahaf.name>wrote:

> danielsh@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700:
> > http://subversion.tigris.org/issues/show_bug.cgi?id=4246
> >
> > In short, hotcopy fails because r1's revprops have been packed.
>
> If anyone wonders how I found this: I read r1358721:1358725, noticed
> that upgrade/pack/recover were mentioned, and tested 'verify' and
> 'hotcopy' - as other operations that take a const char *fs_path, rather
> than an svn_fs_t *fs.
>

Oops. Thanks for noticing! Should be fixed now.

-- Stefan^2.

-- 
*

Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*