[GitHub] [lucene] mocobeta edited a comment on pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

[GitBox <gi...@apache.org>]

mocobeta edited a comment on pull request #643:
URL: https://github.com/apache/lucene/pull/643#issuecomment-1029842772


   > One thing that I wanted to add: We should add @deprecated(forRemoval=true), this makes builds very noisy if you use the deprecated API. By adding a since="9.1" tag we may also remove it earlier than 10.0.
   
   > Of course the deprecated APIs should not merged into "main", but maybe it is easier to keep them in in first commit and rmove in a secondary PR afterwards only in main.
   
   Thanks, I was thinking the same thing. Marks as Deprecated the two-args constructors for removal on branch_9x, and removes them on main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org