You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/19 18:40:20 UTC

[GitHub] [nifi] ChrisSamo632 commented on pull request #4667: NIFI-6403 and NIFI-6404

ChrisSamo632 commented on pull request #4667:
URL: https://github.com/apache/nifi/pull/4667#issuecomment-730563161


   > I just had a look over the code and it LGTM.
   > @ijokarumawak, I'm pinging you in case you want to have a look as well on your side?
   
   Noticed that while the `PutElasticsearchRecord` and other processors that use the `ElasticsearchClient` (mentioned by @MikeThomsen in the original PR) already support optional `type`, it could be a little more explicit and a test added, so I'll aim to do that along with rebasing against `main` following the recent merge of #4665.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org