You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/23 07:55:12 UTC
[GitHub] [incubator-shenyu] hezhaoming opened a new pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
hezhaoming opened a new pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117
// Describe your PR here; eg. Fixes #issueNo
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] tydhot commented on a change in pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#discussion_r714685635
##########
File path: shenyu-web/src/test/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilderTest.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.web.loader;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.File;
+
+/**
+ * Test for ShenyuPluginPathBuilder.
+ */
+public final class ShenyuPluginPathBuilderTest {
+
+
+ /**
+ * test for Custom path
+ */
+ @Test
+ public void getPluginPath1() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("D:\\testpath");
+ Assert.assertNotNull(pluginPath);
+ }
+
+
+ /**
+ * test for plugin-ext
+ * -Dplugin-ext=D:\testUrl
+ */
+ @Test
+ public void getPluginPath2() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("");
+ Assert.assertNotNull(pluginPath);
+ }
+
+ /**
+ * test for default path
+ */
+ @Test
+ public void getPluginPath3() {
Review comment:
plz don't name a method like this `****3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on a change in pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#discussion_r714555658
##########
File path: shenyu-web/src/test/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilderTest.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.web.loader;
+
+import org.junit.Test;
+
+import java.io.File;
+
+/**
+ * Test for ShenyuPluginPathBuilder.
+ */
+public final class ShenyuPluginPathBuilderTest {
+
+
+ /**
+ * test for Custom path
+ */
+ @Test
+ public void getPluginPath1() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("D:\\testpath");
+ }
+
+
+ /**
+ * test for plugin-ext
+ * -Dplugin-ext=D:\testUrl
+ */
+ @Test
+ public void getPluginPath2() {
Review comment:
pls add assert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.93%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.25% -0.94%
+ Complexity 4033 4007 -26
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1734 +10
============================================
- Hits 10855 10747 -108
- Misses 6302 6524 +222
+ Partials 880 867 -13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `26.47% <0.00%> (-23.53%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (-9.71%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.89% -0.29%
Complexity 4033 4033
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
+ Hits 10855 10864 +9
- Misses 6302 6392 +90
- Partials 880 882 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `73.68% <0.00%> (-1.76%)` | :arrow_down: |
| [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `86.04% <0.00%> (-0.74%)` | :arrow_down: |
| [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.85% <0.00%> (-0.11%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...ache/shenyu/common/dto/convert/DivideUpstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9EaXZpZGVVcHN0cmVhbS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] hezhaoming commented on a change in pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
hezhaoming commented on a change in pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#discussion_r714567209
##########
File path: shenyu-web/src/main/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilder.java
##########
@@ -31,15 +31,15 @@
* The type Shenyu plugin path builder.
*/
public final class ShenyuPluginPathBuilder {
-
Review comment:
ok
##########
File path: shenyu-web/src/test/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilderTest.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.web.loader;
+
+import org.junit.Test;
+
+import java.io.File;
+
+/**
+ * Test for ShenyuPluginPathBuilder.
+ */
+public final class ShenyuPluginPathBuilderTest {
+
+
+ /**
+ * test for Custom path
+ */
+ @Test
+ public void getPluginPath1() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("D:\\testpath");
+ }
+
+
+ /**
+ * test for plugin-ext
+ * -Dplugin-ext=D:\testUrl
+ */
+ @Test
+ public void getPluginPath2() {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on a change in pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#discussion_r714555460
##########
File path: shenyu-web/src/main/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilder.java
##########
@@ -31,15 +31,15 @@
* The type Shenyu plugin path builder.
*/
public final class ShenyuPluginPathBuilder {
-
Review comment:
donot modify this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3af6d78 differs from pull request most recent head 44666d9. Consider uploading reports for the commit 44666d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.92% -0.26%
- Complexity 4033 4036 +3
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
+ Hits 10855 10870 +15
- Misses 6302 6390 +88
+ Partials 880 878 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `73.68% <0.00%> (-1.76%)` | :arrow_down: |
| [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `86.04% <0.00%> (-0.74%)` | :arrow_down: |
| [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.85% <0.00%> (-0.11%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...ache/shenyu/common/dto/convert/DivideUpstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9EaXZpZGVVcHN0cmVhbS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...44666d9](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3af6d78 differs from pull request most recent head 44666d9. Consider uploading reports for the commit 44666d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.80% -0.38%
+ Complexity 4033 4031 -2
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
- Hits 10855 10847 -8
- Misses 6302 6413 +111
+ Partials 880 878 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `36.76% <0.00%> (-13.24%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `58.00% <0.00%> (-2.00%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `73.68% <0.00%> (-1.76%)` | :arrow_down: |
| [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `86.04% <0.00%> (-0.74%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...44666d9](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] hezhaoming commented on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
hezhaoming commented on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-925604885
Resume format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] hezhaoming commented on a change in pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
hezhaoming commented on a change in pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#discussion_r715283490
##########
File path: shenyu-web/src/test/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilderTest.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.web.loader;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.File;
+
+/**
+ * Test for ShenyuPluginPathBuilder.
+ */
+public final class ShenyuPluginPathBuilderTest {
+
+
+ /**
+ * test for Custom path
+ */
+ @Test
+ public void getPluginPath1() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("D:\\testpath");
+ Assert.assertNotNull(pluginPath);
+ }
+
+
+ /**
+ * test for plugin-ext
+ * -Dplugin-ext=D:\testUrl
+ */
+ @Test
+ public void getPluginPath2() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("");
+ Assert.assertNotNull(pluginPath);
+ }
+
+ /**
+ * test for default path
+ */
+ @Test
+ public void getPluginPath3() {
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] tydhot commented on a change in pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#discussion_r715287593
##########
File path: shenyu-web/src/test/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilderTest.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.web.loader;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.File;
+
+/**
+ * Test for ShenyuPluginPathBuilder.
+ */
+public final class ShenyuPluginPathBuilderTest {
+
+
+ /**
+ * test for Custom path.
+ */
+ @Test
+ public void testGetPluginPathByCustomPath() {
+ File pluginPath = ShenyuPluginPathBuilder.getPluginPath("D:\\testpath");
Review comment:
I am not sure it would be ok in linux or mac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.21% -0.97%
+ Complexity 4033 4008 -25
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1734 +10
============================================
- Hits 10855 10740 -115
- Misses 6302 6529 +227
+ Partials 880 869 -11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `26.47% <0.00%> (-23.53%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.10% <0.00%> (-18.45%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3af6d78 differs from pull request most recent head 44666d9. Consider uploading reports for the commit 44666d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.38% -0.80%
+ Complexity 4033 4014 -19
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1734 +10
============================================
- Hits 10855 10771 -84
- Misses 6302 6501 +199
+ Partials 880 866 -14
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `36.76% <0.00%> (-13.24%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (-9.71%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...44666d9](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.43%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3af6d78 differs from pull request most recent head 44666d9. Consider uploading reports for the commit 44666d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.74% -0.44%
+ Complexity 4033 4031 -2
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
- Hits 10855 10837 -18
- Misses 6302 6425 +123
+ Partials 880 876 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `36.76% <0.00%> (-13.24%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (-9.71%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `58.00% <0.00%> (-2.00%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `73.68% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...44666d9](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.46%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.71% -0.47%
+ Complexity 4033 4025 -8
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
- Hits 10855 10832 -23
- Misses 6302 6421 +119
- Partials 880 885 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `33.82% <0.00%> (-16.18%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `58.94% <0.00%> (-4.22%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `58.00% <0.00%> (-2.00%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.90% -0.28%
Complexity 4033 4033
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
+ Hits 10855 10865 +10
- Misses 6302 6390 +88
- Partials 880 883 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `86.04% <0.00%> (-0.74%)` | :arrow_down: |
| [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.85% <0.00%> (-0.11%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...ache/shenyu/common/dto/convert/DivideUpstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9EaXZpZGVVcHN0cmVhbS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/shenyu/common/dto/convert/rule/RuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL1J1bGVIYW5kbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.82%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.36% -0.83%
+ Complexity 4033 4009 -24
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1734 +10
============================================
- Hits 10855 10767 -88
- Misses 6302 6497 +195
+ Partials 880 874 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `33.82% <0.00%> (-16.18%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.41%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.76% -0.42%
+ Complexity 4033 4027 -6
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
- Hits 10855 10841 -14
- Misses 6302 6414 +112
- Partials 880 883 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `33.82% <0.00%> (-16.18%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `58.00% <0.00%> (-2.00%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `73.68% <0.00%> (-1.76%)` | :arrow_down: |
| [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `86.04% <0.00%> (-0.74%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.94%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3af6d78 differs from pull request most recent head 44666d9. Consider uploading reports for the commit 44666d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.24% -0.95%
+ Complexity 4033 4009 -24
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1734 +10
============================================
- Hits 10855 10745 -110
- Misses 6302 6523 +221
+ Partials 880 870 -10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `26.47% <0.00%> (-23.53%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.10% <0.00%> (-18.45%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...44666d9](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af6d78) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3af6d78 differs from pull request most recent head 44666d9. Consider uploading reports for the commit 44666d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.81% -0.37%
+ Complexity 4033 4031 -2
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1735 +11
============================================
- Hits 10855 10849 -6
- Misses 6302 6411 +109
+ Partials 880 878 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `47.36% <ø> (+47.36%)` | :arrow_up: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `36.76% <0.00%> (-13.24%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| [...rg/apache/shenyu/loadbalancer/entity/Upstream.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9lbnRpdHkvVXBzdHJlYW0uamF2YQ==) | `39.39% <0.00%> (-5.06%)` | :arrow_down: |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vQXBhY2hlRHViYm9QbHVnaW4uamF2YQ==) | `51.61% <0.00%> (-1.96%)` | :arrow_down: |
| [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `73.68% <0.00%> (-1.76%)` | :arrow_down: |
| [...shenyu/admin/service/impl/SelectorServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1NlbGVjdG9yU2VydmljZUltcGwuamF2YQ==) | `86.04% <0.00%> (-0.74%)` | :arrow_down: |
| [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `1.85% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...44666d9](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2117: [ISSUE #2079] Add unit test for ShenyuPluginPathBuilder
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2117:
URL: https://github.com/apache/incubator-shenyu/pull/2117#issuecomment-926313600
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2117](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4838df2) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a5a6a0901cbe7305bd602353fe222c3c5a45fd7b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5a6a09) will **decrease** coverage by `0.93%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4838df2 differs from pull request most recent head 3af6d78. Consider uploading reports for the commit 3af6d78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2117 +/- ##
============================================
- Coverage 60.18% 59.25% -0.94%
+ Complexity 4033 4007 -26
============================================
Files 612 613 +1
Lines 18037 18138 +101
Branches 1724 1734 +10
============================================
- Hits 10855 10747 -108
- Misses 6302 6524 +222
+ Partials 880 867 -13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/web/loader/ShenyuPluginPathBuilder.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luUGF0aEJ1aWxkZXIuamF2YQ==) | `36.84% <ø> (+36.84%)` | :arrow_up: |
| [...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlscy5qYXZh) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
| [...he/dubbo/handler/ApacheDubboPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vaGFuZGxlci9BcGFjaGVEdWJib1BsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `27.90% <0.00%> (-55.43%)` | :arrow_down: |
| [...ache/shenyu/client/tars/common/dto/TarsRpcExt.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9jb21tb24vZHRvL1RhcnNScGNFeHQuamF2YQ==) | `0.00% <0.00%> (-30.77%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `64.70% <0.00%> (-29.42%)` | :arrow_down: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `26.47% <0.00%> (-23.53%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (-9.71%)` | :arrow_down: |
| [.../common/dto/convert/rule/impl/DubboRuleHandle.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvRHViYm9SdWxlSGFuZGxlLmphdmE=) | `8.82% <0.00%> (-8.42%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2117/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5a6a09...3af6d78](https://codecov.io/gh/apache/incubator-shenyu/pull/2117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org