You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2020/11/23 23:47:41 UTC
[httpcomponents-core] 06/07: Use Collections.addAll() API instead
of loops.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit 757bb7f7f803dad52b5e4e5c9bf3a9f299ddd87e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Nov 23 12:06:09 2020 -0500
Use Collections.addAll() API instead of loops.
---
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java | 4 +---
.../src/main/java/org/apache/hc/core5/ssl/SSLContextBuilder.java | 9 +++------
.../org/apache/hc/core5/http/message/TestMessageSupport.java | 5 ++---
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java b/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
index c8f3fa7..89768e9 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
@@ -630,9 +630,7 @@ public class URIBuilder {
} else {
this.queryParams.clear();
}
- for (final NameValuePair nvp: nvps) {
- this.queryParams.add(nvp);
- }
+ Collections.addAll(this.queryParams, nvps);
this.encodedQuery = null;
this.encodedSchemeSpecificPart = null;
this.query = null;
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContextBuilder.java b/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContextBuilder.java
index 89ecac2..1a2b69d 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContextBuilder.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContextBuilder.java
@@ -46,6 +46,7 @@ import java.security.UnrecoverableKeyException;
import java.security.cert.CertificateException;
import java.security.cert.X509Certificate;
import java.util.Collection;
+import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashSet;
import java.util.Map;
@@ -210,9 +211,7 @@ public class SSLContextBuilder {
}
}
}
- for (final TrustManager tm : tms) {
- this.trustManagers.add(tm);
- }
+ Collections.addAll(this.trustManagers, tms);
}
return this;
}
@@ -282,9 +281,7 @@ public class SSLContextBuilder {
}
}
}
- for (final KeyManager km : kms) {
- keyManagers.add(km);
- }
+ Collections.addAll(keyManagers, kms);
}
return this;
}
diff --git a/httpcore5/src/test/java/org/apache/hc/core5/http/message/TestMessageSupport.java b/httpcore5/src/test/java/org/apache/hc/core5/http/message/TestMessageSupport.java
index cf80a4d..5426c70 100644
--- a/httpcore5/src/test/java/org/apache/hc/core5/http/message/TestMessageSupport.java
+++ b/httpcore5/src/test/java/org/apache/hc/core5/http/message/TestMessageSupport.java
@@ -28,6 +28,7 @@
package org.apache.hc.core5.http.message;
import java.nio.charset.StandardCharsets;
+import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.Set;
@@ -47,9 +48,7 @@ public class TestMessageSupport {
return null;
}
final Set<String> set = new LinkedHashSet<>();
- for (final String token: tokens) {
- set.add(token);
- }
+ Collections.addAll(set, tokens);
return set;
}