You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/09 11:20:21 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #10212: Disable sentry integration by default
potiuk commented on a change in pull request #10212:
URL: https://github.com/apache/airflow/pull/10212#discussion_r467571020
##########
File path: airflow/sentry.py
##########
@@ -57,135 +57,130 @@ def flush(self):
"""
-class ConfiguredSentry(DummySentry):
- """
- Configure Sentry SDK.
- """
-
- SCOPE_TAGS = frozenset(
- ("task_id", "dag_id", "execution_date", "operator", "try_number")
- )
- SCOPE_CRUMBS = frozenset(("task_id", "state", "operator", "duration"))
-
- UNSUPPORTED_SENTRY_OPTIONS = frozenset(
- ("integrations", "in_app_include", "in_app_exclude", "ignore_errors",
- "before_breadcrumb", "before_send", "transport")
- )
+Sentry: DummySentry = DummySentry()
+if conf.getboolean("sentry", 'sentry_on', fallback=False):
+ import sentry_sdk
Review comment:
Love it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org