Re: [PR] feat: Improves waterfall chart [superset]

["anantaoutlook (via GitHub)" <gi...@apache.org>]

anantaoutlook commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2212431788


##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/buildQuery.ts:
##########
@@ -28,6 +28,25 @@ export default function buildQuery(formData: QueryFormData) {
     ...ensureIsArray(x_axis || granularity_sqla),
     ...ensureIsArray(groupby),
   ];
+
+  if (columns.indexOf(formData.seriesOrderByColumn) === -1) {

Review Comment:
   removed the changes from build query, now sort by x axis column and order of x axis sort column are now handled in transformProps



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org