You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/12/04 07:21:21 UTC
Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout test
duration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40956/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Reduced HealthCheckTest.CheckCommandTimeout test duration.
Diffs
-----
src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
Diff: https://reviews.apache.org/r/40956/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout
test duration.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40956/#review110515
-----------------------------------------------------------
Ship it!
Ship It!
src/tests/health_check_tests.cpp (line 866)
<https://reviews.apache.org/r/40956/#comment170436>
Could you also change `local` to true here? So that we could get more details about healthy check process when next failure.
- haosdent huang
On Dec. 4, 2015, 6:24 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40956/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 6:24 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reduced HealthCheckTest.CheckCommandTimeout test duration to 1.5 seconds locally.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
>
> Diff: https://reviews.apache.org/r/40956/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout
test duration.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40956/#review108954
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40956]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 4, 2015, 6:24 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40956/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 6:24 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reduced HealthCheckTest.CheckCommandTimeout test duration to 1.5 seconds locally.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
>
> Diff: https://reviews.apache.org/r/40956/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 40956: Reduced HealthCheckTest.CheckCommandTimeout
test duration.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40956/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 6:24 a.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description (updated)
-------
Reduced HealthCheckTest.CheckCommandTimeout test duration to 1.5 seconds locally.
Diffs
-----
src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
Diff: https://reviews.apache.org/r/40956/diff/
Testing
-------
make check
Thanks,
Timothy Chen