[GitHub] [spark] sumeetgajjar commented on a diff in pull request #37325: [SPARK-39902][SQL] Add Scan details to spark plan scan node in SparkUI

[GitBox <gi...@apache.org>]

sumeetgajjar commented on code in PR #37325:
URL: https://github.com/apache/spark/pull/37325#discussion_r935094151


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -132,4 +132,10 @@ case class BatchScanExec(
     val result = s"$nodeName$truncatedOutputString ${scan.description()} $runtimeFiltersString"
     redact(result)
   }
+
+  /**
+   * Returns the name of this type of TreeNode.  Defaults to the class name.
+   * Note that we remove the "Exec" suffix for physical operators here.
+   */
+  override def nodeName: String = s"BatchScan ${scan.name()}"

Review Comment:
   >  Can we simply use v2 `Table.name`?
   
   Hi @cloud-fan - thank you for your comment, can you please tell me how can we use v2 `Table#name()` here?
   `Scan` or `BatchScanExec` does not have a reference to `Table`. Thus I decided to use `Scan#name()`. 
   
   I would be happy to publish a patch that uses v2 `Table#name()` if you can please tell me how it can be accessed.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org