You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "dwsmith1983 (via GitHub)" <gi...@apache.org> on 2026/10/14 02:41:53 UTC
[PR] ci: label Delta pull requests with area:Delta [datafusion-comet]
dwsmith1983 opened a new pull request, #6965:
URL: https://github.com/apache/datafusion-comet/pull/6965
## Which issue does this PR close?
Closes #6964.
## Rationale for this change
Delta pull requests get no area label of their own. A change under `contrib/**` is labeled `area:scan`, and Delta code outside `contrib/`, such as `native/core/src/execution/delta_dv.rs`, gets nothing Delta specific, while Iceberg pull requests get `area:Iceberg`.
## What changes are included in this PR?
An `area:Delta` rule in `.github/labeler.yml`. It lists the Delta paths explicitly (both contrib modules, the three native Delta files under `native/core/src/execution/`, the Delta workflows, the gate script and the Delta user guide page) instead of copying the Iceberg rule's name glob, since `*[Dd]elta*` would also match the Iceberg delta-write code in `spark/src/main/scala/org/apache/comet/iceberg/` and its shims.
## How are these changes tested?
I ran each glob through minimatch with `dot: true`, as the labeler does, against the file list on `main`. Every file whose path contains "delta" matches except the Iceberg delta-write files. Run over the changed files of recent pull requests, the rule labels #6945, #6932, #6838 and #6270, and leaves #5869 (delta encoding for cached longs) and #6664 (Iceberg writes) alone.
The `area:Delta` label does not exist yet, and `label_prs.yml` grants only `pull-requests: write`, so the labeler cannot create it. Its single `setLabels` call would then fail and drop the other path labels too. Please create the label before merging, for example with the color and style of the other area labels:
```shell
gh label create area:Delta --repo apache/datafusion-comet --color C5DEF5 --description "Delta Lake contrib (native scan, deletion vectors)"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: label Delta pull requests with area:Delta [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6965:
URL: https://github.com/apache/datafusion-comet/pull/6965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: label Delta pull requests with area:Delta [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #6965:
URL: https://github.com/apache/datafusion-comet/pull/6965#issuecomment-6236852838
I created the label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org