You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2018/01/29 07:55:29 UTC
Review Request 65376: Reverted `protobuf::read(path)` to return
`Result`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65376/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jie Yu.
Bugs: MESOS-8481
https://issues.apache.org/jira/browse/MESOS-8481
Repository: mesos
Description
-------
Due to the performance hits of `fsync`, the current implementation
of `state::checkpoint` does not invoke `fsync` prior to `rename`.
As a result, according to this blog post:
https://thunk.org/tytso/blog/2009/03/12/delayed-allocation-and-
the-zero-length-file-problem/
If the agent machine crashes after `rename` is called but before
the buffer has been flushed, the file will end up being empty.
This reverts commit 4f9cda17e1a747bc3c4ab3667569304e09600b29.
Diffs
-----
3rdparty/stout/include/stout/protobuf.hpp 7e7659814a5d95c41c4dfabb5669fd061dff4716
Diff: https://reviews.apache.org/r/65376/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 65376: Reverted `protobuf::read(path)` to return
`Result`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65376/#review196407
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 28, 2018, 11:55 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65376/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2018, 11:55 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
>
>
> Bugs: MESOS-8481
> https://issues.apache.org/jira/browse/MESOS-8481
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to the performance hits of `fsync`, the current implementation
> of `state::checkpoint` does not invoke `fsync` prior to `rename`.
>
> As a result, according to this blog post:
>
> https://thunk.org/tytso/blog/2009/03/12/delayed-allocation-and-
> the-zero-length-file-problem/
>
> If the agent machine crashes after `rename` is called but before
> the buffer has been flushed, the file will end up being empty.
>
> This reverts commit 4f9cda17e1a747bc3c4ab3667569304e09600b29.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/protobuf.hpp 7e7659814a5d95c41c4dfabb5669fd061dff4716
>
>
> Diff: https://reviews.apache.org/r/65376/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 65376: Reverted `protobuf::read(path)` to return
`Result`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65376/#review196457
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Jan. 29, 2018, 7:55 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65376/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 7:55 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
>
>
> Bugs: MESOS-8481
> https://issues.apache.org/jira/browse/MESOS-8481
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to the performance hits of `fsync`, the current implementation
> of `state::checkpoint` does not invoke `fsync` prior to `rename`.
>
> As a result, according to this blog post:
>
> https://thunk.org/tytso/blog/2009/03/12/delayed-allocation-and-
> the-zero-length-file-problem/
>
> If the agent machine crashes after `rename` is called but before
> the buffer has been flushed, the file will end up being empty.
>
> This reverts commit 4f9cda17e1a747bc3c4ab3667569304e09600b29.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/protobuf.hpp 7e7659814a5d95c41c4dfabb5669fd061dff4716
>
>
> Diff: https://reviews.apache.org/r/65376/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>