[jira] Commented: (SOLR-2100) Fix for saving commit points during java-based backups

["Yonik Seeley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906408#action_12906408 ] 

Yonik Seeley commented on SOLR-2100:
------------------------------------

Thanks for the patch Peter!  Such a small patch... but I've been trying to puzzle out all of the possible ramifications (and going back to puzzle through some of the replication code).

saveCommitPoint() (which obviously did nothing before this) is called in the postCommit (and postOptimize) events.
This doesn't even seem necessary for replication, since SolrDeletionPolicy always saves the last commit point and the last optimized point (if configured to do so, or if replicate on optimize is configured).  Once replication has started, a reservation scheme is used rather than saving a commit point forever.

Also, if one configures replication onCommit and onOptimize, then the event callback code has some bugs: both refer to indexCommitPoint, and close the previous one.  So if we did rely on saveCommitPoint, a commit after an optimize would release the optimized commit point.

> Fix for saving commit points during java-based backups
> ------------------------------------------------------
>
>                 Key: SOLR-2100
>                 URL: https://issues.apache.org/jira/browse/SOLR-2100
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>    Affects Versions: 1.4, 1.4.1
>            Reporter: Peter Sturge
>            Priority: Minor
>             Fix For: 1.4.2
>
>         Attachments: SOLR-2100.PATCH
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch fixes the saving of commit points during backup operations.
> This fixes the perviously commited (for 1.4) SOLR-1475 patch.
> 1. In IndexDeletionPolicyWrapper.java, commit points are not saved to the 'savedCommits' map.
> 2. Also, the testing of the presence of a commit point uses the contains() method instead of containsKey().
> The result of this means that backups for anything but toy indexes fail, because the commit points are deleted (after 10s) before the full backup is completed.
> This patch addresses these 2 issues.
> Tested with 1.4.1 release trunk, but should also work fine with 1.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org