You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/12 08:21:18 UTC
Review Request 28987: Added an allocator unit test for allocatable
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28987/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
This was not covered in the unit tests, and I almost introduced a regression here when only the sum of reserved and unreserved resources are allocatable.
We still need a test for filters, but one step at a time.. ;)
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09
Diff: https://reviews.apache.org/r/28987/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28987: Added an allocator unit test for allocatable
resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28987/#review64945
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28987/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 7:21 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This was not covered in the unit tests, and I almost introduced a regression here when only the sum of reserved and unreserved resources are allocatable.
>
> We still need a test for filters, but one step at a time.. ;)
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09
>
> Diff: https://reviews.apache.org/r/28987/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>