You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/12 08:45:40 UTC

[GitHub] [flink] 1996fanrui opened a new pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

1996fanrui opened a new pull request #14614:
URL: https://github.com/apache/flink/pull/14614


   ## What is the purpose of the change
   
   Support configuration of RocksDB log level
   
   ## Brief change log
   
     - add config `state.backend.rocksdb.log.level`
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Check whether the configuration takes effect 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented?  docs 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 457aa2f37debac811974499fcb61a35a5d0933d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913) 
   * 0df4cd109f84a5ff5d314bb23ce10d862bda4e90 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-759423349


   @Myasuka 
   The configuration of `state.backend.rocksdb.log.level` has added documentation, but the unit test of the documentation failed. I don't know how to solve it. Can you help me when you are free? Thanks.
   
   [link](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=11931&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=62110053-334f-5295-a0ab-80dd7e2babbf&l=33211)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui removed a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui removed a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758670142


   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758504127


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 926ffcf5f7b81e189e72339c7579fd73dd6715e9 (Fri May 28 07:08:04 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030",
       "triggerID" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "926ffcf5f7b81e189e72339c7579fd73dd6715e9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "926ffcf5f7b81e189e72339c7579fd73dd6715e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030) 
   * 926ffcf5f7b81e189e72339c7579fd73dd6715e9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-760157254


   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Myasuka commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-759487910


   How do you generate the configuration in html?
   From the error message, it should be `Flink choose 'HEADER_LEVEL'` instead of `Flink choose HEADER_LEVEL` in your PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Myasuka commented on a change in pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #14614:
URL: https://github.com/apache/flink/pull/14614#discussion_r555641799



##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
##########
@@ -64,6 +71,20 @@
                             "The maximum number of open files (per TaskManager) that can be used by the DB, '-1' means no limit. "
                                     + "RocksDB has default configuration as '-1'.");
 
+    public static final ConfigOption<InfoLogLevel> LOG_LEVEL =
+            key("state.backend.rocksdb.log.level")
+                    .enumType(InfoLogLevel.class)
+                    .noDefaultValue()
+                    .withDescription(String.format(
+                            "The specified log level for DB. Candidate log level is %s, %s, %s, %s, %s or %s, "
+                                    + "and Flink choose '%s' as default style. "

Review comment:
       I think we could remove this line as it add description of `so Flink sets the RocksDB log level to HEADER_LEVEL by default.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758504127


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 457aa2f37debac811974499fcb61a35a5d0933d5 (Tue Jan 12 08:48:39 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 457aa2f37debac811974499fcb61a35a5d0933d5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] Myasuka merged pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #14614:
URL: https://github.com/apache/flink/pull/14614


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758670142


   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-760630571


   @Myasuka Thank you for your help and review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 457aa2f37debac811974499fcb61a35a5d0933d5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030",
       "triggerID" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "926ffcf5f7b81e189e72339c7579fd73dd6715e9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12043",
       "triggerID" : "926ffcf5f7b81e189e72339c7579fd73dd6715e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030) 
   * 926ffcf5f7b81e189e72339c7579fd73dd6715e9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12043) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0df4cd109f84a5ff5d314bb23ce10d862bda4e90 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923) 
   * 879417b9fbfe847c1a90de5caef7817edd10d69a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0df4cd109f84a5ff5d314bb23ce10d862bda4e90 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923) 
   * 879417b9fbfe847c1a90de5caef7817edd10d69a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 879417b9fbfe847c1a90de5caef7817edd10d69a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931) 
   * f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui removed a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui removed a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758615676


   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui commented on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758615676


   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030",
       "triggerID" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0df4cd109f84a5ff5d314bb23ce10d862bda4e90 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] 1996fanrui commented on a change in pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on a change in pull request #14614:
URL: https://github.com/apache/flink/pull/14614#discussion_r555685613



##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
##########
@@ -64,6 +71,20 @@
                             "The maximum number of open files (per TaskManager) that can be used by the DB, '-1' means no limit. "
                                     + "RocksDB has default configuration as '-1'.");
 
+    public static final ConfigOption<InfoLogLevel> LOG_LEVEL =
+            key("state.backend.rocksdb.log.level")
+                    .enumType(InfoLogLevel.class)
+                    .noDefaultValue()
+                    .withDescription(String.format(
+                            "The specified log level for DB. Candidate log level is %s, %s, %s, %s, %s or %s, "
+                                    + "and Flink choose '%s' as default style. "

Review comment:
       @Myasuka Thanks for your review. I have removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030",
       "triggerID" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "926ffcf5f7b81e189e72339c7579fd73dd6715e9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12043",
       "triggerID" : "926ffcf5f7b81e189e72339c7579fd73dd6715e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 926ffcf5f7b81e189e72339c7579fd73dd6715e9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12043) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 879417b9fbfe847c1a90de5caef7817edd10d69a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14614: [FLINK-20911][state-backend-rocksdb] Support configuration of RocksDB log level

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14614:
URL: https://github.com/apache/flink/pull/14614#issuecomment-758512892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11913",
       "triggerID" : "457aa2f37debac811974499fcb61a35a5d0933d5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11923",
       "triggerID" : "0df4cd109f84a5ff5d314bb23ce10d862bda4e90",
       "triggerType" : "PUSH"
     }, {
       "hash" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931",
       "triggerID" : "879417b9fbfe847c1a90de5caef7817edd10d69a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030",
       "triggerID" : "f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 879417b9fbfe847c1a90de5caef7817edd10d69a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11931) 
   * f3a5b0e4feb3bf16edecba4946fc0d160d7a4bce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12030) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org