You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jacob Barrett <jb...@pivotal.io> on 2017/10/23 17:35:23 UTC
[Discussion] Native Region::registerAllKeys
This function has an optional out variable to capture the list of keys that
get registered in this function. There are no tests that test the behavior
of the function where the out variable is provided. The API deviates from
the Java API which does not return the list of keys. Converting to return
value means that either every call returns the list of keys, thus removing
the optional behavior, or an additional flag must be provided on the
parameter list to indicate that the return should be populated or not. Both
are not great solutions.
I propose that we remove the optional parameter leaving the function return
as void.
-Jake
Re: [Discussion] Native Region::registerAllKeys
Posted by Ernest Burghardt <eb...@pivotal.io>.
+1 for aligning APIs
On Mon, Oct 23, 2017 at 11:35 AM, Jacob Barrett <jb...@pivotal.io> wrote:
> This function has an optional out variable to capture the list of keys that
> get registered in this function. There are no tests that test the behavior
> of the function where the out variable is provided. The API deviates from
> the Java API which does not return the list of keys. Converting to return
> value means that either every call returns the list of keys, thus removing
> the optional behavior, or an additional flag must be provided on the
> parameter list to indicate that the return should be populated or not. Both
> are not great solutions.
>
> I propose that we remove the optional parameter leaving the function return
> as void.
>
> -Jake
>
[VOTE] Native Region::registerAllKeys
Posted by Jacob Barrett <jb...@pivotal.io>.
+1 remove optional parameter and return void.
> On Oct 23, 2017, at 10:35 AM, Jacob Barrett <jb...@pivotal.io> wrote:
>
> This function has an optional out variable to capture the list of keys that get registered in this function. There are no tests that test the behavior of the function where the out variable is provided. The API deviates from the Java API which does not return the list of keys. Converting to return value means that either every call returns the list of keys, thus removing the optional behavior, or an additional flag must be provided on the parameter list to indicate that the return should be populated or not. Both are not great solutions.
>
> I propose that we remove the optional parameter leaving the function return as void.
>
> -Jake
>