You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/11 16:59:21 UTC

[GitHub] [druid] capistrant commented on pull request #10913: Fix a resource leak in JobHelper

capistrant commented on pull request #10913:
URL: https://github.com/apache/druid/pull/10913#issuecomment-796887549


   > LGTM.
   > 
   > I think it's ok to manually override the coverage check for this change since the LGTM bot is saying this one line change fixes the resource leak. What do you think @capistrant ?
   > 
   > I've manually triggered the integration tests, just to make sure there are no unintended consequences (I doubt there will be any legitimate test failures 🤞 )
   
   I'd be fine with that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org