You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/12/01 17:54:15 UTC

[GitHub] [netbeans] KacerCZ opened a new pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

KacerCZ opened a new pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573


   https://issues.apache.org/jira/browse/NETBEANS-5075
   
   Removes multiple empty lines from PHP code.
   Adds setting under Formatting/PHP/Blank Lines.
   
   Formatting options:
   ![netbeans-5075](https://user-images.githubusercontent.com/4249184/100777756-84f48e80-3406-11eb-9fd5-9e77ac406aba.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739504015


   @KacerCZ Thanks for your time and work! And for your patience with my comments :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739463613


   @tmysik Failed job is "Build the Visual Studio Code extension for Java". So, maybe I think it is not related this change. (I reran the job but it failed.)
   
   @hectorespert Do you know anything about this? We can ignore it, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536967876



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=
+FmtBlankLines.maxPreservedLabel.text=Max Preserved Lines:

Review comment:
       I see now... OK then. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536898935



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739462293


   @KacerCZ Could you please check the CI failures whether they are unrelated? Thank you.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536960706



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=
+FmtBlankLines.maxPreservedLabel.text=Max Preserved Lines:

Review comment:
       Changing text to "Max Preserved Blank Lines:" widens panel.
   I hope meaning of this setting will be clear from category as @junichi11 says.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 edited a comment on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-738473723


   I would add the option to enable this feature (I would disable it by default because (maybe) there is no strong request until now). Some users may add new lines intentionally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536899089



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=
+FmtBlankLines.maxPreservedLabel.text=Max Preserved Lines:

Review comment:
       Changed name to `maxPreservedBlankFiled` and `maxPreservedBlankLabel`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r535919623



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,8 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.jTextField1.text=jTextField1

Review comment:
       Yes, removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536879973



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=
+FmtBlankLines.maxPreservedLabel.text=Max Preserved Lines:

Review comment:
       Please, add "blank" everywhere here as it is not apparent what exactly it does. The constant as well as the Symfony rule contains it. Thanks.
   
   CC @junichi11 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536912572



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=
+FmtBlankLines.maxPreservedLabel.text=Max Preserved Lines:

Review comment:
       Well, I was talking about the text of the label, not the label name. But thanks for changing it too and sorry for not being clear. Please, improve the label so it is obvious what lines are going to be preserved. Thanks!
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-775844067


   @terax6669 If you have a problem, please report it to the JIRA: https://issues.apache.org/jira/projects/NETBEANS/issues
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-738609845


   This option removes blank lines only if there are more blank lines than configured value.
   In default setting it keeps only blank single line and removes all extra lines.
   This formatting is used in Symfony framework - https://cs.symfony.com/ rule "no_extra_blank_lines".
   
   If user wants to keep more lines, then it can be set to higher value.
   Only setting this value to 0 will remove blank lines from code completely.
   
   Other lines around properties, methods, classes are not affected by this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] terax6669 commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
terax6669 commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-775810090


   Those are my current settings. I believe I've had issues with properties touching the traits or constants. I can't remember - it was quite a while ago.
   ![netbeans64_WUCImgWJsp](https://user-images.githubusercontent.com/19204073/107345799-404f3880-6ac4-11eb-96ca-c69caf1cb476.png)
   
   Anyway, this way I am able to keep the inside of the class tidy, but the unfortunate side effect is that the beginning and end of class have additional blank lines. Will this pr fix this? (If it's already possible please instruct me how to fix my settings)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-738473723


   I would add the option to enable this feature. Some users may add new lines intentionally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739569685


   @hectorespert Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-738635015


   Ah, I see now. OK.Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 edited a comment on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739463613


   @tmysik Failed job is "Build the Visual Studio Code extension for Java". So, maybe I think it is not related to this change. (I reran the job but it failed.)
   
   @hectorespert Do you know anything about this? We can ignore it(merge this PR), right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536879769



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=

Review comment:
       Nitpick: The given text field can be set to be "NOI18N" in its properties (this line would not be here than).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739501570


   @junichi11 @tmysik Thanks for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] hectorespert commented on pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#issuecomment-739482397


   > @hectorespert Do you know anything about this? We can ignore it(merge this PR), right?
   
   Yes, that job is failing in other branches too
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r536940195



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,7 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.maxPreservedField.text=
+FmtBlankLines.maxPreservedLabel.text=Max Preserved Lines:

Review comment:
       @tmysik Maybe, I suppose @KacerCZ did not add it because Category is Blank Lines.
   
   ![nb2573-formatting-option](https://user-images.githubusercontent.com/738383/101270099-17a37d80-37b9-11eb-9367-ad895063c183.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #2573: [NETBEANS-5075] Remove consecutive empty lines when formatting PHP code

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2573:
URL: https://github.com/apache/netbeans/pull/2573#discussion_r535745300



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/indent/ui/Bundle.properties
##########
@@ -430,3 +430,8 @@ FmtWrapping.groupUseListLabel.text=G&roup Use List:
 FmtWrapping.groupUseBracesCheckBox.text_1=Group &Use Braces
 FmtBraces.groupUseLabel.text=G&roup Use:
 FmtAlignment.noteLabel.text=<html><i>Note: These options depend on Wrapping settings</i></html>
+FmtBlankLines.jTextField1.text=jTextField1

Review comment:
       Remove?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists