You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/06 22:07:14 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new issue #10543: [dashboard edit] No Switch to view mode option
graceguo-supercat opened a new issue #10543:
URL: https://github.com/apache/incubator-superset/issues/10543
#### How to reproduce the bug
1. Go to Dashboard
2. Click on "Edit", dashboard will be in edit mode
3. Now I want to switch back to view mode **without** any edit:
### Expected results
<img width="1152" alt="Screen Shot 2020-08-06 at 2 56 24 PM" src="https://user-images.githubusercontent.com/27990562/89586701-0c354b00-d7f5-11ea-8ebb-1319c93dbf05.png">
### Actual results
<img width="1374" alt="Screen Shot 2020-08-06 at 2 44 50 PM" src="https://user-images.githubusercontent.com/27990562/89586272-3e927880-d7f4-11ea-98f4-07c4cfadfb4c.png">
Click "DISCARD CHANGES" will reload page, it will take some time (if dashboard is large). **And** if user was in a tab, reload page will lost user's previous focused tab.
The old behavior is, if there is no change in the dashboard, we show "SWITCH TO VIEW MODE" button, and click button will only switch mode, no page reload.
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Related to #10394
@mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #10543: [dashboard edit] No Switch to view mode option
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #10543:
URL: https://github.com/apache/incubator-superset/issues/10543#issuecomment-671583426
ping @mistercrunch @rusackas What do you think of setting color scheme function for dashboard? Do we just remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10543: [dashboard edit] No Switch to view mode option
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10543:
URL: https://github.com/apache/incubator-superset/issues/10543#issuecomment-706542883
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10543: [dashboard edit] No Switch to view mode option
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10543:
URL: https://github.com/apache/incubator-superset/issues/10543#issuecomment-670215244
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.69. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org