You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/24 23:29:43 UTC

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22841: [Website] add Python implementation to KinesisIO

TheNeuralBit commented on code in PR #22841:
URL: https://github.com/apache/beam/pull/22841#discussion_r954377506


##########
website/www/site/content/en/documentation/io/connectors.md:
##########
@@ -252,7 +252,10 @@ This table provides a consolidated, at-a-glance overview of the available built-
       ✔
       <a href="https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/kinesis/KinesisIO.html">native</a>
     </td>
-    <td>Not available</td>
+    <td class="present">
+      ✔
+      <a href="https://beam.apache.org/releases/pydoc/current/apache_beam.io.kinesis.html#apache_beam.io.kinesis.ReadDataFromKinesis">native</a>

Review Comment:
   This is actually exposed via cross-language: https://github.com/apache/beam/blob/ddfb6907288369bfc71c3a310cb9ceb717a4d3a0/sdks/python/apache_beam/io/kinesis.py#L196-L201
   
   (note the "ExternalTransform")
   ```suggestion
         <a href="https://beam.apache.org/releases/pydoc/current/apache_beam.io.kinesis.html#apache_beam.io.kinesis.ReadDataFromKinesis">via X-language</a>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org