You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/12/29 16:33:04 UTC

[GitHub] [httpcomponents-core] garydgregory opened a new pull request #178: Httpcore 618 http status as a class

garydgregory opened a new pull request #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o commented on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569891078
 
 
   @garydgregory Please do not merge unsquashed branches with a merge commit in the future. This produces a lot of noise and lowers the readability of the log.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o removed a comment on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o removed a comment on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569789355
 
 
   The branch is now uptodate and ready to be merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#discussion_r361873170
 
 

 ##########
 File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
 ##########
 @@ -46,118 +46,118 @@
  * @see <a href="https://tools.ietf.org/html/rfc2295">RFC2295 (Transparent Content Negotiation)</a>
  * @since 4.0
  */
-public interface HttpStatus {
+public class HttpStatus {
 
 Review comment:
   Also here maybe:
   
   ```
       private StandardCharsets() {
           throw new AssertionError("No java.nio.charset.StandardCharsets instances for you!");
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o commented on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569899202
 
 
   > 
   > 
   > > @garydgregory Please do not merge unsquashed branches with a merge commit in the future. This produces a lot of noise and lowers the readability of the log.
   > 
   > Это какой то лютый п***ц
   
   согласен!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o commented on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569806260
 
 
   Looks good. Please do a fixup and merge to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c commented on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
ok2c commented on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569898720
 
 
   > @garydgregory Please do not merge unsquashed branches with a merge commit in the future. This produces a lot of noise and lowers the readability of the log.
   
   Это какой то лютый п***ц

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o commented on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569789355
 
 
   The branch is now uptodate and ready to be merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] garydgregory merged pull request #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] michael-o commented on issue #178: Httpcore 618 http status as a class

Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #178: Httpcore 618 http status as a class
URL: https://github.com/apache/httpcomponents-core/pull/178#issuecomment-569545940
 
 
   @garydgregory Should this one be final?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org