You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/20 09:31:04 UTC
[GitHub] [doris] TangSiyang2001 opened a new pull request, #16123: [enhancement-wip] Support BE http service with brpc
TangSiyang2001 opened a new pull request, #16123:
URL: https://github.com/apache/doris/pull/16123
# Proposed changes
Issue Number: close ##16087
## Problem summary
Doris BE uses `libevent` to support http service currently, which is planned to be replaced by `brpc` step by step in the future.
Doris BE has `webserver_port` for http service and `brpc_port` for internal service. The brpc-based http service will share the `brpc_port` with internal service, and `webserver_port` will be kept for libevent-based http service at the current stage.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439292636
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444950955
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442798476
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1438680679
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437052296
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439252874
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #16123:
URL: https://github.com/apache/doris/pull/16123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1092165206
##########
be/src/http/brpc/handler_dispatcher.h:
##########
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <memory>
+#include <mutex>
+#include <unordered_map>
+
+#include "brpc_http_handler.h"
+#include "runtime/exec_env.h"
+
+namespace doris {
+using Closure = ::google::protobuf::Closure;
+using RpcController = ::google::protobuf::RpcController;
+using HttpHandlerPtr = BaseHttpHandler*;
+using HandlerRegistry = std::unordered_map<std::string, HttpHandlerPtr>;
+using RegistryPtr = std::unique_ptr<HandlerRegistry>;
+class HandlerDispatcher {
+public:
+ HandlerDispatcher();
+
+ void dispatch(const std::string& handler_name, RpcController* cntl, Closure* done);
+
+ HandlerDispatcher* add_handler(BaseHttpHandler* handler);
+
+private:
+ std::mutex _mutex;
+ RegistryPtr _registry;
+ bool _registered;
Review Comment:
warning: private field '_registered' is not used [clang-diagnostic-unused-private-field]
```cpp
bool _registered;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1403344287
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439303812
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439610802
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437065821
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436235451
Didn't implement StreamLoadAction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442682870
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437697297
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436336356
>
Cause no MonitorAction is registered to the original webserver, it seems redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436346413
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] platoneko commented on a diff in pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1116473698
##########
be/src/http/brpc/action/tablets_distribution_action.cpp:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "tablets_distribution_action.h"
+
+#include <brpc/http_method.h>
+#include <glog/logging.h>
+
+#include "olap/data_dir.h"
+#include "olap/storage_engine.h"
+
+namespace doris {
+TabletsDistributionHandler::TabletsDistributionHandler()
+ : BaseHttpHandler("tablets_distribution") {}
+
+EasyJson TabletsDistributionHandler::get_tablets_distribution_group_by_partition(
+ brpc::Controller* cntl, uint64_t partition_id) {
+ std::map<int64_t, std::map<DataDir*, int64_t>> tablets_num_on_disk;
+ std::map<int64_t, std::map<DataDir*, std::vector<TabletSize>>> tablets_info_on_disk;
+ TabletManager* tablet_manager = StorageEngine::instance()->tablet_manager();
+ tablet_manager->get_tablets_distribution_on_different_disks(tablets_num_on_disk,
+ tablets_info_on_disk);
+
+ EasyJson tablets_distribution_ej;
+ tablets_distribution_ej["msg"] = "OK";
+ tablets_distribution_ej["code"] = 0;
+ EasyJson data = tablets_distribution_ej.Set("data", EasyJson::kObject);
+ data["host"] = get_localhost(cntl).c_str();
+ EasyJson tablets_distribution = data.Set("tablets_distribution", EasyJson::kArray);
+ int64_t tablet_total_number = 0;
+ std::map<int64_t, std::map<DataDir*, int64_t>>::iterator partition_iter =
+ tablets_num_on_disk.begin();
+ for (; partition_iter != tablets_num_on_disk.end(); ++partition_iter) {
+ if (partition_id != 0 && partition_id != partition_iter->first) {
+ continue;
+ }
+ EasyJson partition = tablets_distribution.PushBack(EasyJson::kObject);
+ partition["partition_id"] = partition_iter->first;
+ EasyJson disks = partition.Set("disks", EasyJson::kArray);
+ std::map<DataDir*, int64_t>::iterator disk_iter = (partition_iter->second).begin();
+ for (; disk_iter != (partition_iter->second).end(); ++disk_iter) {
+ EasyJson disk = disks.PushBack(EasyJson::kObject);
+ disk["disk_path"] = disk_iter->first->path();
+ disk["tablets_num"] = disk_iter->second;
+ tablet_total_number += disk_iter->second;
+ if (partition_id != 0) {
+ EasyJson tablets = disk.Set("tablets", EasyJson::kArray);
+ for (int64_t i = 0;
+ i < tablets_info_on_disk[partition_iter->first][disk_iter->first].size();
+ i++) {
+ EasyJson tablet = tablets.PushBack(EasyJson::kObject);
+ tablet["tablet_id"] =
+ tablets_info_on_disk[partition_iter->first][disk_iter->first][i]
+ .tablet_id;
+ tablet["schema_hash"] =
+ tablets_info_on_disk[partition_iter->first][disk_iter->first][i]
+ .schema_hash;
+ tablet["tablet_size"] =
+ tablets_info_on_disk[partition_iter->first][disk_iter->first][i]
+ .tablet_size;
+ }
+ }
+ }
+ }
+ tablets_distribution_ej["count"] = tablet_total_number;
+ return tablets_distribution_ej;
+}
+
+void TabletsDistributionHandler::handle_sync(brpc::Controller* cntl) {
+ const std::string* req_group_method = get_param(cntl, "group_by");
+ if (req_group_method == nullptr) {
+ on_bad_req(cntl, "invalid null param: group_by");
+ return;
+ }
+ if (*req_group_method == "partition") {
+ const std::string* req_partition_id = get_param(cntl, "partition_id");
+ uint64_t partition_id = 0;
+ if (req_partition_id != nullptr) {
+ try {
+ partition_id = std::stoull(*req_partition_id);
+ } catch (const std::exception& e) {
+ LOG(WARNING) << "invalid argument. partition_id:" << *req_partition_id;
+ Status status = Status::InternalError("invalid argument: {}", *req_partition_id);
+ std::string status_result = status.to_json();
+ on_error_json(cntl, status_result);
+ return;
+ }
+ }
+ on_succ_json(cntl,
+ get_tablets_distribution_group_by_partition(cntl, partition_id).ToString());
+ return;
+ }
+ LOG(WARNING) << "invalid argument. group_by:" << *req_group_method;
+ Status status = Status::InternalError(strings::Substitute("invalid argument: group_by"));
+ std::string status_result = status.to_json();
Review Comment:
`strings::Substitute` seems redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1443756578
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444952081
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1440265454
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1440265182
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437169917
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437170358
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436278494
> Didn't implement StreamLoadAction?
Yes, brpc does not support continuous reception with http, . After discussing with @dataroaring, we decided to implement it in another way, and the implementation will be in another pr, so that @xiaojunjie is able to start https works smoothly.
Currently, I am focusing on regression-test and will make it completed as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1434024268
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1420631491
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1420625985
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1403377434
> Is there a way to keep http port unchanged but using brpc implemented http server?
Yes, doris has now got a brpc port for internal service and has established a brpc server. Becase brpc server supports several services ,we can add the new http service to this server to share the brpc port, and the original http port is completely unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1083432080
##########
be/src/http/action/checksum_action.h:
##########
@@ -25,11 +25,11 @@ namespace doris {
class ExecEnv;
-class ChecksumAction : public HttpHandler {
+class CheckSumAction : public HttpHandler {
public:
- explicit ChecksumAction();
+ explicit CheckSumAction();
- virtual ~ChecksumAction() {}
+ virtual ~CheckSumAction() {}
Review Comment:
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
```suggestion
virtual ~CheckSumAction() = default;
```
##########
be/src/http/action/checksum_action.cpp:
##########
@@ -41,9 +41,9 @@ const std::string TABLET_ID = "tablet_id";
const std::string TABLET_VERSION = "version";
const std::string SCHEMA_HASH = "schema_hash";
-ChecksumAction::ChecksumAction() {}
+CheckSumAction::CheckSumAction() {}
Review Comment:
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
```suggestion
CheckSumAction::CheckSumAction() = default;
```
##########
be/src/http/action/checksum_action.h:
##########
@@ -25,11 +25,11 @@
class ExecEnv;
-class ChecksumAction : public HttpHandler {
+class CheckSumAction : public HttpHandler {
public:
- explicit ChecksumAction();
+ explicit CheckSumAction();
- virtual ~ChecksumAction() {}
+ virtual ~CheckSumAction() {}
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
```suggestion
~CheckSumAction() override {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "yangzhg (via GitHub)" <gi...@apache.org>.
yangzhg commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1429019911
@xiaojunjie pay attention to his pr, this maybe conflict with be support https/auth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439303182
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436216181
Didn't implement StreamLoadAction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436345645
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1441891638
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444980638
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439502670
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444953705
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442885394
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1109247360
##########
be/src/http/brpc/action/pad_rowset_action.cpp:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "pad_rowset_action.h"
+
+#include <brpc/http_method.h>
+
+#include "olap/olap_common.h"
+#include "olap/rowset/beta_rowset_writer.h"
+#include "olap/rowset/rowset.h"
+#include "olap/storage_engine.h"
+
+namespace doris {
+
+const std::string TABLET_ID = "tablet_id";
+const std::string START_VERSION = "start_version";
+const std::string END_VERSION = "end_version";
+
+Status check_uniq_param(const std::string& param_val, const std::string& param_name) {
+ if (param_val.empty()) {
+ return Status::InternalError("paramater {} not specified in url", param_name);
+ }
+ return Status::OK();
+}
+
+PadRowsetHandler::PadRowsetHandler() : BaseHttpHandler("pad_rowset") {}
+
+void PadRowsetHandler::handle_sync(brpc::Controller* cntl) {
+ Status status = _handle(cntl);
+ std::string result = status.to_json();
+ LOG(INFO) << "handle request result:" << result;
+ if (status.ok()) {
+ on_succ(cntl, result);
+ } else {
+ on_error(cntl, result);
+ }
+}
+
+bool PadRowsetHandler::support_method(brpc::HttpMethod method) const {
+ return method == brpc::HTTP_METHOD_POST;
+}
+
+Status PadRowsetHandler::_handle(brpc::Controller* cntl) {
+ RETURN_IF_ERROR(check_param(cntl));
+
+ const std::string& tablet_id_str = *get_param(cntl, TABLET_ID);
+ const std::string& start_version_str = *get_param(cntl, START_VERSION);
+ const std::string& end_version_str = *get_param(cntl, END_VERSION);
+
+ // valid str format
+ int64_t tablet_id = std::atol(tablet_id_str.c_str());
+ int32_t start_version = std::atoi(start_version_str.c_str());
+ int32_t end_version = std::atoi(end_version_str.c_str());
+ if (start_version < 0 || end_version < 0 || end_version < start_version) {
+ return Status::InternalError("Invalid input version");
+ }
+
+ auto tablet = StorageEngine::instance()->tablet_manager()->get_tablet(tablet_id);
+ if (nullptr == tablet) {
+ return Status::InternalError("Unknown tablet id {}", tablet_id);
+ }
+ return _pad_rowset(tablet, Version(start_version, end_version));
+}
+
+Status PadRowsetHandler::check_param(brpc::Controller* cntl) {
+ RETURN_IF_ERROR(check_uniq_param(*get_param(cntl, TABLET_ID), TABLET_ID));
+ RETURN_IF_ERROR(check_uniq_param(*get_param(cntl, START_VERSION), START_VERSION));
+ RETURN_IF_ERROR(check_uniq_param(*get_param(cntl, END_VERSION), END_VERSION));
+ return Status::OK();
+}
+
+Status PadRowsetHandler::_pad_rowset(TabletSharedPtr tablet, const Version& version) {
+ if (tablet->check_version_exist(version)) {
+ return Status::InternalError("Input version {} exists", version.to_string());
+ }
+
+ std::unique_ptr<RowsetWriter> writer;
+ RowsetWriterContext ctx;
+ ctx.version = version;
+ ctx.rowset_state = VISIBLE;
+ ctx.segments_overlap = NONOVERLAPPING;
+ ctx.tablet_schema = tablet->tablet_schema();
+ ctx.oldest_write_timestamp = UnixSeconds();
Review Comment:
warning: no member named 'oldest_write_timestamp' in 'doris::RowsetWriterContext'; did you mean 'newest_write_timestamp'? [clang-diagnostic-error]
```suggestion
ctx.newest_write_timestamp = UnixSeconds();
```
**be/src/olap/rowset/rowset_writer_context.h:79:** 'newest_write_timestamp' declared here
```cpp
int64_t newest_write_timestamp;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1434047740
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437069243
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1116496416
##########
be/src/http/brpc/action/tablets_distribution_action.cpp:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "tablets_distribution_action.h"
+
+#include <brpc/http_method.h>
+#include <glog/logging.h>
+
+#include "olap/data_dir.h"
+#include "olap/storage_engine.h"
+
+namespace doris {
+TabletsDistributionHandler::TabletsDistributionHandler()
+ : BaseHttpHandler("tablets_distribution") {}
+
+EasyJson TabletsDistributionHandler::get_tablets_distribution_group_by_partition(
+ brpc::Controller* cntl, uint64_t partition_id) {
+ std::map<int64_t, std::map<DataDir*, int64_t>> tablets_num_on_disk;
+ std::map<int64_t, std::map<DataDir*, std::vector<TabletSize>>> tablets_info_on_disk;
+ TabletManager* tablet_manager = StorageEngine::instance()->tablet_manager();
+ tablet_manager->get_tablets_distribution_on_different_disks(tablets_num_on_disk,
+ tablets_info_on_disk);
+
+ EasyJson tablets_distribution_ej;
+ tablets_distribution_ej["msg"] = "OK";
+ tablets_distribution_ej["code"] = 0;
+ EasyJson data = tablets_distribution_ej.Set("data", EasyJson::kObject);
+ data["host"] = get_localhost(cntl).c_str();
+ EasyJson tablets_distribution = data.Set("tablets_distribution", EasyJson::kArray);
+ int64_t tablet_total_number = 0;
+ std::map<int64_t, std::map<DataDir*, int64_t>>::iterator partition_iter =
+ tablets_num_on_disk.begin();
+ for (; partition_iter != tablets_num_on_disk.end(); ++partition_iter) {
+ if (partition_id != 0 && partition_id != partition_iter->first) {
+ continue;
+ }
+ EasyJson partition = tablets_distribution.PushBack(EasyJson::kObject);
+ partition["partition_id"] = partition_iter->first;
+ EasyJson disks = partition.Set("disks", EasyJson::kArray);
+ std::map<DataDir*, int64_t>::iterator disk_iter = (partition_iter->second).begin();
+ for (; disk_iter != (partition_iter->second).end(); ++disk_iter) {
+ EasyJson disk = disks.PushBack(EasyJson::kObject);
+ disk["disk_path"] = disk_iter->first->path();
+ disk["tablets_num"] = disk_iter->second;
+ tablet_total_number += disk_iter->second;
+ if (partition_id != 0) {
+ EasyJson tablets = disk.Set("tablets", EasyJson::kArray);
+ for (int64_t i = 0;
+ i < tablets_info_on_disk[partition_iter->first][disk_iter->first].size();
+ i++) {
+ EasyJson tablet = tablets.PushBack(EasyJson::kObject);
+ tablet["tablet_id"] =
+ tablets_info_on_disk[partition_iter->first][disk_iter->first][i]
+ .tablet_id;
+ tablet["schema_hash"] =
+ tablets_info_on_disk[partition_iter->first][disk_iter->first][i]
+ .schema_hash;
+ tablet["tablet_size"] =
+ tablets_info_on_disk[partition_iter->first][disk_iter->first][i]
+ .tablet_size;
+ }
+ }
+ }
+ }
+ tablets_distribution_ej["count"] = tablet_total_number;
+ return tablets_distribution_ej;
+}
+
+void TabletsDistributionHandler::handle_sync(brpc::Controller* cntl) {
+ const std::string* req_group_method = get_param(cntl, "group_by");
+ if (req_group_method == nullptr) {
+ on_bad_req(cntl, "invalid null param: group_by");
+ return;
+ }
+ if (*req_group_method == "partition") {
+ const std::string* req_partition_id = get_param(cntl, "partition_id");
+ uint64_t partition_id = 0;
+ if (req_partition_id != nullptr) {
+ try {
+ partition_id = std::stoull(*req_partition_id);
+ } catch (const std::exception& e) {
+ LOG(WARNING) << "invalid argument. partition_id:" << *req_partition_id;
+ Status status = Status::InternalError("invalid argument: {}", *req_partition_id);
+ std::string status_result = status.to_json();
+ on_error_json(cntl, status_result);
+ return;
+ }
+ }
+ on_succ_json(cntl,
+ get_tablets_distribution_group_by_partition(cntl, partition_id).ToString());
+ return;
+ }
+ LOG(WARNING) << "invalid argument. group_by:" << *req_group_method;
+ Status status = Status::InternalError(strings::Substitute("invalid argument: group_by"));
+ std::string status_result = status.to_json();
Review Comment:
OK, I'll modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1116579584
##########
be/src/http/brpc/action/stream_load_2pc.cpp:
##########
@@ -0,0 +1,146 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "stream_load_2pc.h"
+
+#include <brpc/http_method.h>
+#include <glog/logging.h>
+#include <rapidjson/prettywriter.h>
+#include <rapidjson/stringbuffer.h>
+
+#include <vector>
+
+#include "http/http_common.h"
+#include "http/http_headers.h"
+#include "runtime/stream_load/stream_load_context.h"
+#include "runtime/stream_load/stream_load_executor.h"
+#include "util/url_coding.h"
+
+namespace doris {
+StreamLoad2PCHandler::StreamLoad2PCHandler(ExecEnv* exec_env)
+ : BaseHttpHandler("stream_load_2pc", exec_env) {}
+
+std::string StreamLoad2PCHandler::get_success_info(const std::string txn_id,
+ const std::string txn_operation) {
+ rapidjson::StringBuffer s;
+ rapidjson::PrettyWriter<rapidjson::StringBuffer> writer(s);
+
+ writer.StartObject();
+ // status
+ writer.Key("status");
+ writer.String("Success");
+ // msg
+ std::string msg = "transaction [" + txn_id + "] " + txn_operation + " successfully.";
+ writer.Key("msg");
+ writer.String(msg.c_str());
+ writer.EndObject();
+ return s.GetString();
+}
+
+void StreamLoad2PCHandler::handle_sync(brpc::Controller* cntl) {
+ Status status = Status::OK();
+ std::string status_result;
+
+ StreamLoadContext* ctx = new StreamLoadContext(get_exec_env());
+ //ctx doesn't need a manually unref
+ ctx->ref();
Review Comment:
warning: no member named 'ref' in 'doris::StreamLoadContext' [clang-diagnostic-error]
```cpp
ctx->ref();
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1443752532
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1443752673
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1117086544
##########
be/src/http/brpc/action/stream_load_2pc.cpp:
##########
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "stream_load_2pc.h"
+
+#include <brpc/http_method.h>
+#include <glog/logging.h>
+#include <rapidjson/prettywriter.h>
+#include <rapidjson/stringbuffer.h>
+
+#include <vector>
+
+#include "http/http_common.h"
+#include "http/http_headers.h"
+#include "runtime/stream_load/stream_load_context.h"
+#include "runtime/stream_load/stream_load_executor.h"
+#include "util/url_coding.h"
+
+namespace doris {
+StreamLoad2PCHandler::StreamLoad2PCHandler(ExecEnv* exec_env)
+ : BaseHttpHandler("stream_load_2pc", exec_env) {}
+
+std::string StreamLoad2PCHandler::get_success_info(const std::string txn_id,
+ const std::string txn_operation) {
+ rapidjson::StringBuffer s;
+ rapidjson::PrettyWriter<rapidjson::StringBuffer> writer(s);
+
+ writer.StartObject();
+ // status
+ writer.Key("status");
+ writer.String("Success");
+ // msg
+ std::string msg = "transaction [" + txn_id + "] " + txn_operation + " successfully.";
+ writer.Key("msg");
+ writer.String(msg.c_str());
+ writer.EndObject();
+ return s.GetString();
+}
+
+void StreamLoad2PCHandler::handle_sync(brpc::Controller* cntl) {
+ Status status = Status::OK();
+ std::string status_result;
+
+ std::shared_ptr<StreamLoadContext> ctx = std::make_shared<StreamLoadContext>(get_exec_env());
+ std::vector<std::string> path_array;
+ get_path_array(cntl, path_array);
+ if (path_array.size() != 3 && path_array.size() != 4) {
+ on_bad_req(cntl, "missing path variable");
+ return;
+ }
+ ctx->db = path_array[1];
+ const std::string* req_txn_id = get_header(cntl, HTTP_TXN_ID_KEY);
+ if (req_txn_id == nullptr) {
+ on_bad_req(cntl, "missing header" + HTTP_TXN_ID_KEY);
+ return;
+ }
+ try {
+ ctx->txn_id = std::stoull(*req_txn_id);
+ } catch (const std::exception& e) {
+ status = Status::InternalError("convert txn_id [{}] failed", *req_txn_id);
+ status_result = status.to_json();
+ on_succ_json(cntl, status_result);
+ return;
+ }
+ ctx->txn_operation = *get_header(cntl, HTTP_TXN_OPERATION_KEY);
+ if (ctx->txn_operation.compare("commit") != 0 && ctx->txn_operation.compare("abort") != 0) {
+ status = Status::InternalError("transaction operation should be \'commit\' or \'abort\'");
+ status_result = status.to_json();
+ on_succ_json(cntl, status_result);
+ return;
+ }
+
+ if (!_parse_basic_auth(cntl, &ctx->auth)) {
+ LOG(WARNING) << "parse basic authorization failed.";
+ status = Status::InternalError("no valid Basic authorization");
+ }
+
+ status = get_exec_env()->stream_load_executor()->operate_txn_2pc(ctx.get());
Review Comment:
warning: no viable conversion from 'std::shared_ptr<StreamLoadContext>' to 'doris::StreamLoadContext *' [clang-diagnostic-error]
```cpp
status = get_exec_env()->stream_load_executor()->operate_txn_2pc(ctx);
^
```
**be/src/runtime/stream_load/stream_load_executor.h:38:** passing argument to parameter 'ctx' here
```cpp
Status operate_txn_2pc(StreamLoadContext* ctx);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439589522
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439292423
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1440264997
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444981975
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444993355
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1403340814
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1407914260
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1413990933
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437705232
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439589677
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444934288
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1438680492
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439252955
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444975810
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439252787
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442682792
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442800913
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1441901870
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1398183708
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.58 seconds
load time: 490 seconds
storage size: 17122274743 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230120102058_clickbench_pr_84689.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1399238167
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1083256275
##########
be/src/service/brpc_http_service.h:
##########
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <string>
+
+#include "gen_cpp/http_service.pb.h"
+#include "http/brpc/handler_dispatcher.h"
+
+namespace doris {
+
+class ExecEnv;
+
+class BrpcHttpService : public PHttpService {
+public:
+ BrpcHttpService(ExecEnv* exec_env);
+ ~BrpcHttpService() = default;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
```suggestion
~BrpcHttpService() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436342364
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437151221
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437094418
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439489688
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1438747160
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437697361
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1438756351
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1440293315
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439263792
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1432462489
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442797879
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442685625
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1082287281
##########
be/src/service/brpc_http_service.h:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <brpc/http_status_code.h>
+#include <brpc/restful.h>
+#include <brpc/server.h>
+
+#include <string>
+
+#include "gen_cpp/http_service.pb.h"
+#include "runtime/exec_env.h"
+#include "util/easy_json.h"
+
+namespace brpc {
+class Controller;
+}
+
+namespace doris {
+class BrpcHttpHelper;
+
+class BrpcHttpService :public PHttpService {
+ BrpcHttpService(ExecEnv* exec_env);
+
+ void check_rpc_channel(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void reset_rpc_channel(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+
+ void config(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void health(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void jeprofile(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void meta(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void metrics(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void monitor(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void pad_rowset(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void pprof(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+ void snapshot(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void version(::google::protobuf::RpcController* controller, const ::doris::HttpRequest* request,
+ ::doris::HttpResponse* response, ::google::protobuf::Closure* done) override;
+
+ void check_tablet_segement(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void check_sum(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void compaction(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void reload_tablet(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void restore_tablet(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void tablet_migration(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void distribution(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void tablet_info(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+
+ void download(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void stream_load(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+ void stream_load_2pc(::google::protobuf::RpcController* controller,
+ const ::doris::HttpRequest* request, ::doris::HttpResponse* response,
+ ::google::protobuf::Closure* done) override;
+
+private:
+ ExecEnv* _exec_env;
Review Comment:
warning: private field '_exec_env' is not used [clang-diagnostic-unused-private-field]
```cpp
ExecEnv* _exec_env;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1428019307
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442649043
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442693176
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442885211
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437066287
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1438702979
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1438680840
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1441912586
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442810682
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444980051
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444981756
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1447449852
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1443743036
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444934140
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1399239386
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1413970256
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439825290
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437697227
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436308506
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1436324682
No MonitorAction in add_brpc_http_service()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1441888019
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1443743166
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1443770024
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444951951
run build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444975749
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444978294
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444978323
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444993599
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439275665
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439489761
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1413945568
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1403395977
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by github-actions.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1403401085
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1402115367
Is there a way to keep http port unchanged but using brpc implemented http server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1420993821
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1434365937
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437066021
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437170109
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1437052447
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [enhancement-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1425984657
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1441889405
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1441901646
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1442800967
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1440264593
buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1439292560
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1444979449
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16123:
URL: https://github.com/apache/doris/pull/16123#issuecomment-1447449793
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org