[pulsar] branch master updated: Fix flaky test testOffloadV2 (#10350)

[pe...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 69a173a  Fix flaky test testOffloadV2 (#10350)
69a173a is described below

commit 69a173a82c89893f54dbe5b6f422249f66ea5418
Author: feynmanlin <fe...@tencent.com>
AuthorDate: Mon Apr 26 19:47:01 2021 +0800

    Fix flaky test testOffloadV2 (#10350)
    
    ### Motivation
    triggerOffload takes some time
    
    ```
    Error:  testOffloadV2(org.apache.pulsar.broker.admin.AdminApiOffloadTest)  Time elapsed: 0.127 s  <<< FAILURE!
    java.lang.AssertionError: expected [SUCCESS] but found [RUNNING]
    	at org.testng.Assert.fail(Assert.java:99)
    	at org.testng.Assert.failNotEquals(Assert.java:1037)
    	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
    	at org.testng.Assert.assertEquals(Assert.java:122)
    	at org.testng.Assert.assertEquals(Assert.java:617)
    	at org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffload(AdminApiOffloadTest.java:135)
    	at org.apache.pulsar.broker.admin.AdminApiOffloadTest.testOffloadV2(AdminApiOffloadTest.java:150)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:498)
    	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
    	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
    	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
    	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
    	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    	at java.lang.Thread.run(Thread.java:748)
    ```
---
 .../java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
index 216893f..9bbb27c 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiOffloadTest.java
@@ -132,8 +132,9 @@ public class AdminApiOffloadTest extends MockedPulsarServiceBaseTest {
 
         admin.topics().triggerOffload(topicName, currentId);
 
-        assertEquals(admin.topics().offloadStatus(topicName).status,
-                            LongRunningProcessStatus.Status.SUCCESS);
+        Awaitility.await().untilAsserted(() ->
+                assertEquals(admin.topics().offloadStatus(topicName).status,
+                LongRunningProcessStatus.Status.SUCCESS));
         MessageIdImpl firstUnoffloaded = admin.topics().offloadStatus(topicName).firstUnoffloadedMessage;
         // First unoffloaded is the first entry of current ledger
         assertEquals(firstUnoffloaded.getLedgerId(), info.ledgers.get(1).ledgerId);