You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Torsten Förtsch <to...@gmx.net> on 2010/05/25 09:19:08 UTC

flood_farm.c

Hi,

flood_farm.c contains these lines for almost 9 years (since Revision 89675):

#if 0 /* this gets uncommented after apr_thread_exit() fixes are commited */
    apr_thread_exit(thd, APR_SUCCESS);
#endif

Are those fixes committed now?

I mean is the apr_thread_exit to be called now or are those 3 lines simply 
superfluous?

Torsten Förtsch

-- 
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

Re: flood_farm.c

Posted by Jeff Trawick <tr...@gmail.com>.

2010/5/25 Torsten Förtsch <to...@gmx.net>:
> Hi,
>
> flood_farm.c contains these lines for almost 9 years (since Revision 89675):
>
> #if 0 /* this gets uncommented after apr_thread_exit() fixes are commited */
>    apr_thread_exit(thd, APR_SUCCESS);
> #endif
>
> Are those fixes committed now?

yes (though different than in the patch referred to by the commit log
for r89675)

sanity check: worker MPM in httpd 2.0 has the same call to apr_thread_exit()

> I mean is the apr_thread_exit to be called now or are those 3 lines simply
> superfluous?

I'm not sure for flood.  It won't hurt to call apr_thread_exit() though.

(For some apps it is important to call apr_thread_exit() so that the
thread pool is destroyed.)