[GitHub] [helix] pkuwm commented on pull request #1344: Reduce unnecessary getChildren call in subscribeForChanges

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1344:
URL: https://github.com/apache/helix/pull/1344#issuecomment-698712073


   This PR is ready to be merged, approved by @jiajunwang 
   
   
   In CallbackHanlder's subscribeForChanges(), children names need to be fetched. subscribeChildChange(path, callbackType) does actually have the children list, but it doesn't return, and later getChildren() is called again. It wastes one zk call: not only wasting time in handling a callback, but also adds more read pressure to zk server.
   
   This commit uses the return result from subscribeChildChange() and saves getChildren() call.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org