You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/11/28 02:59:48 UTC
[GitHub] [incubator-echarts] pissang commented on issue #11367: Fix 11236
integrate stack/tile button into one toggle button in toolbox
pissang commented on issue #11367: Fix 11236 integrate stack/tile button into one toggle button in toolbox
URL: https://github.com/apache/incubator-echarts/pull/11367#issuecomment-559321970
The current implementation:
> Icon itself did not switch between stack/tiled, only the title and emphasis status changed
makes more sense. It's more similar to the other icons.
Besides this, I think the `tile` icon <img src="https://user-images.githubusercontent.com/841551/69773544-1dda4380-11ce-11ea-9ecd-9726099e281f.png" /> is not necessary anymore. We can remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org