You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2025/01/17 19:53:40 UTC
[PR] RATIS-2241. Enforce Hugo version. [ratis]
szetszwo opened a new pull request, #1213:
URL: https://github.com/apache/ratis/pull/1213
## What changes were proposed in this pull request?
- Enforce Hugo version: v0.141.0 (latest)
- Update Rat version 0.13 -> 0.16.1
- Update rat-excludes.txt
- Avoid "echo -e" since some systems may just print out "-e".
- Regenerate lifecycle.svg
## What is the link to the Apache JIRA
RATIS-2241
## How was this patch tested?
Tested manually by setting the expected version to v0.140.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #1213:
URL: https://github.com/apache/ratis/pull/1213#discussion_r1935100312
##########
build.sh:
##########
@@ -83,9 +83,9 @@ if [ ! -d "$DIR/build/apache-rat-${rat_version}" ]; then
tar zxf build/${filename} -C build/
fi
-echo "Running RAT license check"
+echo "Running RAT license check on $DIR"
output=$(java -jar $DIR/build/apache-rat-${rat_version}/apache-rat-${rat_version}.jar -d $DIR -E rat-excludes.txt)
-if [[ ! $(echo "$output" | grep '0 Unknown Licenses') ]]; then
+if [[ ! $(echo "$output" | grep '^0 Unknown Licenses') ]]; then
Review Comment:
Nice catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1213:
URL: https://github.com/apache/ratis/pull/1213#issuecomment-2621493614
`public` is in `.gitignore`, and prior to this change it was also included in `rat-excludes.txt`. So Rat is expected to ignore it. Maybe we need to tweak this entry:
https://github.com/apache/ratis/blob/ba1a8aba9631904839cb4032b9264594b99cdc41/.gitignore#L7
or restore:
https://github.com/apache/ratis/blob/ba1a8aba9631904839cb4032b9264594b99cdc41/rat-excludes.txt#L17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1213:
URL: https://github.com/apache/ratis/pull/1213#issuecomment-2623194684
@adoroszlai , you are right that we should also remove `public` from `gitignore`.
@SzyWilliam , I see the problem now. The `public` dir is the default `hugo` output dir. We should discourage running the `hugo` command directly since it may not have run the license check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Enforce Hugo version. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1213:
URL: https://github.com/apache/ratis/pull/1213#issuecomment-2599794323
@SzyWilliam, thanks for trying out!
```
Files with unapproved licenses:
/Users/william/Desktop/ratis/build.log
/Users/william/Desktop/ratis/public/categories.html
/Users/william/Desktop/ratis/public/community.html
/Users/william/Desktop/ratis/public/getting_started.html
```
I guess these files probably were generated from previous Hugo versions. We should manually remove them before running `build.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #1213:
URL: https://github.com/apache/ratis/pull/1213#discussion_r1935123543
##########
build.sh:
##########
@@ -83,9 +83,9 @@ if [ ! -d "$DIR/build/apache-rat-${rat_version}" ]; then
tar zxf build/${filename} -C build/
fi
-echo "Running RAT license check"
+echo "Running RAT license check on $DIR"
output=$(java -jar $DIR/build/apache-rat-${rat_version}/apache-rat-${rat_version}.jar -d $DIR -E rat-excludes.txt)
-if [[ ! $(echo "$output" | grep '0 Unknown Licenses') ]]; then
+if [[ ! $(echo "$output" | grep '^0 Unknown Licenses') ]]; then
Review Comment:
I had 10 files generated in the `public` but passed the licenses check since the command `grep '0 Unknown Licenses'` matched it.
```
10 Unknown Licenses
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1213:
URL: https://github.com/apache/ratis/pull/1213#issuecomment-2623198048
@SzyWilliam , @adoroszlai , please take a look the new commit. Thank you in advance.
BTW, we should setup rat check in git action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1213:
URL: https://github.com/apache/ratis/pull/1213#issuecomment-2628452514
@SzyWilliam , @adoroszlai , thanks a lot for revising this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2241. Website: Enforce Hugo version. [ratis]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1213:
URL: https://github.com/apache/ratis/pull/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org