You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (Created) (JIRA)" <ji...@apache.org> on 2012/04/12 18:13:22 UTC

[jira] [Created] (THRIFT-1569) thrift: add stop() method to python TNonblockingServer

thrift: add stop() method to python TNonblockingServer

-------------------------------------------------------

                 Key: THRIFT-1569
                 URL: https://issues.apache.org/jira/browse/THRIFT-1569
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Library
            Reporter: Dave Watson
            Priority: Minor
         Attachments: 0011-thrift-add-stop-method-to-python-TNonblockingServer.patch

>From d296862f25500360e5dbf46dd79be8c78cb3d309 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <si...@fb.com>
Date: Tue, 14 Dec 2010 22:52:08 +0000
Subject: [PATCH 11/12] thrift: add stop() method to python TNonblockingServer

Summary:
Add a stop() method that causes serve() to return.  This can be invoked
from within the handler or from another thread.

Test Plan:
Called stop(), verified the server stopped but was still listening on
the server socket.  Verified that calling serve() again resumed
processing pending connections accepted by the kernel while serve() was
not running.

Tested calling stop(), then close() after serve() returned and verified
that the server was no longer listening on the socket and new
connections were refused.  Tested calling serve() again to make sure the
server could still be restarted from this state.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1569) thrift: add stop() method to python TNonblockingServer

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253443#comment-13253443 ] 

Hudson commented on THRIFT-1569:
--------------------------------

Integrated in Thrift #437 (See [https://builds.apache.org/job/Thrift/437/])
    THRIFT-1569 thrift: add stop() method to python TNonblockingServer
Patch: Dave Watson (Revision 1325784)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1325784
Files : 
* /thrift/trunk/lib/py/src/server/TNonblockingServer.py

                
> thrift: add stop() method to python TNonblockingServer

> -------------------------------------------------------
>
>                 Key: THRIFT-1569
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1569
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>         Attachments: 0011-thrift-add-stop-method-to-python-TNonblockingServer.patch
>
>
> From d296862f25500360e5dbf46dd79be8c78cb3d309 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Tue, 14 Dec 2010 22:52:08 +0000
> Subject: [PATCH 11/12] thrift: add stop() method to python TNonblockingServer
> Summary:
> Add a stop() method that causes serve() to return.  This can be invoked
> from within the handler or from another thread.
> Test Plan:
> Called stop(), verified the server stopped but was still listening on
> the server socket.  Verified that calling serve() again resumed
> processing pending connections accepted by the kernel while serve() was
> not running.
> Tested calling stop(), then close() after serve() returned and verified
> that the server was no longer listening on the socket and new
> connections were refused.  Tested calling serve() again to make sure the
> server could still be restarted from this state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1569) thrift: add stop() method to python TNonblockingServer

Posted by "Dave Watson (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Watson updated THRIFT-1569:
--------------------------------

    Attachment: 0011-thrift-add-stop-method-to-python-TNonblockingServer.patch
    
> thrift: add stop() method to python TNonblockingServer

> -------------------------------------------------------
>
>                 Key: THRIFT-1569
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1569
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Priority: Minor
>         Attachments: 0011-thrift-add-stop-method-to-python-TNonblockingServer.patch
>
>
> From d296862f25500360e5dbf46dd79be8c78cb3d309 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Tue, 14 Dec 2010 22:52:08 +0000
> Subject: [PATCH 11/12] thrift: add stop() method to python TNonblockingServer
> Summary:
> Add a stop() method that causes serve() to return.  This can be invoked
> from within the handler or from another thread.
> Test Plan:
> Called stop(), verified the server stopped but was still listening on
> the server socket.  Verified that calling serve() again resumed
> processing pending connections accepted by the kernel while serve() was
> not running.
> Tested calling stop(), then close() after serve() returned and verified
> that the server was no longer listening on the socket and new
> connections were refused.  Tested calling serve() again to make sure the
> server could still be restarted from this state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (THRIFT-1569) thrift: add stop() method to python TNonblockingServer

Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1569.
---------------------------------

    Resolution: Fixed
      Assignee: Dave Watson

thanks Dave!
                
> thrift: add stop() method to python TNonblockingServer

> -------------------------------------------------------
>
>                 Key: THRIFT-1569
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1569
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>         Attachments: 0011-thrift-add-stop-method-to-python-TNonblockingServer.patch
>
>
> From d296862f25500360e5dbf46dd79be8c78cb3d309 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Tue, 14 Dec 2010 22:52:08 +0000
> Subject: [PATCH 11/12] thrift: add stop() method to python TNonblockingServer
> Summary:
> Add a stop() method that causes serve() to return.  This can be invoked
> from within the handler or from another thread.
> Test Plan:
> Called stop(), verified the server stopped but was still listening on
> the server socket.  Verified that calling serve() again resumed
> processing pending connections accepted by the kernel while serve() was
> not running.
> Tested calling stop(), then close() after serve() returned and verified
> that the server was no longer listening on the socket and new
> connections were refused.  Tested calling serve() again to make sure the
> server could still be restarted from this state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira