You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/10 06:57:21 UTC

[GitHub] [ozone] ayushtkn commented on pull request #1904: HDDS-4802. Fix an internal variable always not null in PipelinePlacementPolicy

ayushtkn commented on pull request #1904:
URL: https://github.com/apache/ozone/pull/1904#issuecomment-776490718


   The test is asserting the exception also which will not happen now
   ```
   catch (SCMException e) {
         Assert.assertEquals(SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE,
             e.getResult());
       } 
   ```
   This we can remove now, since it won't hit post this change.
   
   In `testFallBackPickNodes` also we can get away from catching the SCMException, since that won't be thrown now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org