You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/28 08:42:05 UTC

[GitHub] [iotdb] Beyyes commented on a diff in pull request #7466: [IOTDB-4549] ConfigNode snapshot test

Beyyes commented on code in PR #7466:
URL: https://github.com/apache/iotdb/pull/7466#discussion_r982119109


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ConsensusManager.java:
##########
@@ -83,6 +84,13 @@ private void setConsensusLayer(PartitionRegionStateMachine stateMachine) throws
                 ConsensusConfig.newBuilder()
                     .setThisNode(new TEndPoint(CONF.getInternalAddress(), CONF.getConsensusPort()))
                     .setStorageDir(CONF.getConsensusDir())
+                    .setRatisConfig(
+                        RatisConfig.newBuilder()
+                            .setSnapshot(
+                                RatisConfig.Snapshot.newBuilder()
+                                    .setAutoTriggerThreshold(100)

Review Comment:
   Is this ok to set the `autoTriggerThreshold` config to 100 in master branch？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org