[jira] [Work logged] (HIVE-17313) Potentially possible 'case fall through' in the ObjectInspectorConverters

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-17313?focusedWorklogId=446675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446675 ]

ASF GitHub Bot logged work on HIVE-17313:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jun/20 16:53
            Start Date: 16/Jun/20 16:53
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on pull request #230:
URL: https://github.com/apache/hive/pull/230#issuecomment-644887052


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 446675)
    Remaining Estimate: 0h
            Time Spent: 10m

> Potentially possible 'case fall through' in the ObjectInspectorConverters
> -------------------------------------------------------------------------
>
>                 Key: HIVE-17313
>                 URL: https://issues.apache.org/jira/browse/HIVE-17313
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17313.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Lines 103-110:
> {code:java}
>     case STRING:
>       if (outputOI instanceof WritableStringObjectInspector) {
>         return new PrimitiveObjectInspectorConverter.TextConverter(
>             inputOI);
>       } else if (outputOI instanceof JavaStringObjectInspector) {
>         return new PrimitiveObjectInspectorConverter.StringConverter(
>             inputOI);
>       }
>     case CHAR:
> {code}
> De-facto it should work correctly since outputOI is either an instance of WritableStringObjectInspector or JavaStringObjectInspector, but it would be better to rewrite this case to avoid possible fall through.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)