You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/07/23 20:51:53 UTC
Review Request 36739: Kerberos: Allow setting/clearing attributes for
MIT KDC identities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-12501
https://issues.apache.org/jira/browse/AMBARI-12501
Repository: ambari
Description
-------
Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
```
-requires_preauth max_renew_life=7d
```
*Solution*
Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
ambari-web/app/data/HDP2/site_properties.js e359a41
Diff: https://reviews.apache.org/r/36739/diff/
Testing
-------
Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
Manually tested enabling Kerbreros to see _custom_ attributes appled
#Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92892
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 24, 2015, 7:06 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 7:06 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results:
>
> Running org.apache.ambari.server.upgrade.UpgradeCatalog211Test
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.822 sec
>
> Tests run: 3133, Failures: 0, Errors: 0, Skipped: 28
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:36 h
> [INFO] Finished at: 2015-07-24T02:50:09+00:00
> [INFO] Final Memory: 46M/624M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/
-----------------------------------------------------------
(Updated July 24, 2015, 7:06 a.m.)
Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-12501
https://issues.apache.org/jira/browse/AMBARI-12501
Repository: ambari
Description
-------
Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
```
-requires_preauth max_renew_life=7d
```
*Solution*
Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
ambari-web/app/data/HDP2/site_properties.js e359a41
Diff: https://reviews.apache.org/r/36739/diff/
Testing (updated)
-------
Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
Manually tested enabling Kerbreros to see _custom_ attributes appled
#Jenkins test results:
Running org.apache.ambari.server.upgrade.UpgradeCatalog211Test
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.822 sec
Tests run: 3133, Failures: 0, Errors: 0, Skipped: 28
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:36 h
[INFO] Finished at: 2015-07-24T02:50:09+00:00
[INFO] Final Memory: 46M/624M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92867
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On July 23, 2015, 8:16 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 8:16 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/
-----------------------------------------------------------
(Updated July 23, 2015, 8:16 p.m.)
Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
Changes
-------
Updates due to reviewer comments.
Bugs: AMBARI-12501
https://issues.apache.org/jira/browse/AMBARI-12501
Repository: ambari
Description
-------
Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
```
-requires_preauth max_renew_life=7d
```
*Solution*
Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
ambari-web/app/data/HDP2/site_properties.js e359a41
Diff: https://reviews.apache.org/r/36739/diff/
Testing
-------
Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
Manually tested enabling Kerbreros to see _custom_ attributes appled
#Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Robert Levas <rl...@hortonworks.com>.
> On July 23, 2015, 8:04 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java, lines 514-517
> > <https://reviews.apache.org/r/36739/diff/1/?file=1020079#file1020079line514>
> >
> > Oh I see now. My bad; you can drop this issue.
Great, thanks.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92839
-----------------------------------------------------------
On July 23, 2015, 2:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 2:51 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92839
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java (lines 489 - 492)
<https://reviews.apache.org/r/36739/#comment147085>
Oh I see now. My bad; you can drop this issue.
- Nate Cole
On July 23, 2015, 2:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 2:51 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Robert Levas <rl...@hortonworks.com>.
> On July 23, 2015, 4:07 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java, lines 514-517
> > <https://reviews.apache.org/r/36739/diff/1/?file=1020079#file1020079line514>
> >
> > Do you need spaces in there? this will put one argument right next to one another. If so, consider StringUtils.join()
It is not clear how I would effectively use StringUtils.join here (and below). Ideally, the goal is to iterate through the items that make up the command and create a string. Each _part_ is analyzed to determine if needs to be quoted or "masked" (as in a password).
Am I missing something?
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92796
-----------------------------------------------------------
On July 23, 2015, 2:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 2:51 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Robert Levas <rl...@hortonworks.com>.
> On July 23, 2015, 4:07 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java, lines 195-196
> > <https://reviews.apache.org/r/36739/diff/1/?file=1020079#file1020079line195>
> >
> > No need for double formatting, logging arguments already via:
> > LOG.error("Failed to execute foo {} with {}", value1, value2)
Fixed in rev 2.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92796
-----------------------------------------------------------
On July 23, 2015, 8:16 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 8:16 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92796
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java (lines 195 - 196)
<https://reviews.apache.org/r/36739/#comment147042>
No need for double formatting, logging arguments already via:
LOG.error("Failed to execute foo {} with {}", value1, value2)
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java (lines 489 - 492)
<https://reviews.apache.org/r/36739/#comment147043>
Do you need spaces in there? this will put one argument right next to one another. If so, consider StringUtils.join()
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java (lines 500 - 506)
<https://reviews.apache.org/r/36739/#comment147044>
Consider StringUtils.join(). Also, another other characters that need escaping, like backslash, etc?
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java (lines 39 - 41)
<https://reviews.apache.org/r/36739/#comment147045>
For 2.1.1.
- Nate Cole
On July 23, 2015, 2:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 2:51 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 36739: Kerberos: Allow setting/clearing attributes
for MIT KDC identities
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92803
-----------------------------------------------------------
Ship it!
A few minor comments ...
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java (line 21)
<https://reviews.apache.org/r/36739/#comment147048>
Might as well clean this up. Unused import.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java (line 47)
<https://reviews.apache.org/r/36739/#comment147046>
It doesn't look like osFamily is actually used.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java (line 52)
<https://reviews.apache.org/r/36739/#comment147047>
Is LOG used?
- Tom Beerbower
On July 23, 2015, 6:51 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 6:51 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-12501
> https://issues.apache.org/jira/browse/AMBARI-12501
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar) KDC.
>
> A user should be able to specify a list of attributes to be set or unset while creating identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
>
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java 33350c0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java 20426f0
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 29fb4b5
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bc45970
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java PRE-CREATION
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml e9665f3
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java d7fffb2
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 9b9a28c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json d56d08e
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691
> ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75
> ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9
> ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d
> ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b
> ambari-web/app/data/HDP2/site_properties.js e359a41
>
> Diff: https://reviews.apache.org/r/36739/diff/
>
>
> Testing
> -------
>
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>