You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/04/11 18:45:05 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2277: FINERACT-1561: Enhancements for APIs
josehernandezfintecheandomx opened a new pull request, #2277:
URL: https://github.com/apache/fineract/pull/2277
## Description
In attention for the ticket
Ignore if these details are present on the associated [Apache Fineract JIRA ticket FINERACT-1561](https://issues.apache.org/jira/browse/FINERACT-1561).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2277: FINERACT-1561: Enhancements for APIs
Posted by GitBox <gi...@apache.org>.
vidakovic commented on code in PR #2277:
URL: https://github.com/apache/fineract/pull/2277#discussion_r847649358
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java:
##########
@@ -144,7 +144,7 @@ public List<GLAccountData> retrieveAllGLAccounts(final Integer accountClassifica
boolean firstWhereConditionAdded = false;
if (accountClassification != null) {
sql += " classification_enum like ?";
- paramaterArray[arrayPos] = accountClassification;
+ paramaterArray[arrayPos] = accountClassification.shortValue();
Review Comment:
Any specific reason why this needs to be a "short" type? Seems a bit odd...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2277: FINERACT-1561: Enhancements for APIs
Posted by GitBox <gi...@apache.org>.
vidakovic commented on code in PR #2277:
URL: https://github.com/apache/fineract/pull/2277#discussion_r847645050
##########
.gitignore:
##########
@@ -21,4 +21,5 @@ bin/
fineract-provider/out/
fineract-provider/config/swagger/config.json
fineract-provider/config/swagger/fineract-input.yaml
-licenses
\ No newline at end of file
+licenses
Review Comment:
Same here... not sure if that is OpenMF specific stuff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2277: FINERACT-1561: Enhancements for APIs
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #2277:
URL: https://github.com/apache/fineract/pull/2277#issuecomment-1098156582
Included in other PR https://github.com/apache/fineract/pull/2279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a diff in pull request #2277: FINERACT-1561: Enhancements for APIs
Posted by GitBox <gi...@apache.org>.
vidakovic commented on code in PR #2277:
URL: https://github.com/apache/fineract/pull/2277#discussion_r847636417
##########
.github/workflows/sonarqube.yml:
##########
@@ -6,9 +6,9 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
+ SONAR_ORGANIZATION: mifos
Review Comment:
This needs to stay untouched
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx closed pull request #2277: FINERACT-1561: Enhancements for APIs
Posted by GitBox <gi...@apache.org>.
josehernandezfintecheandomx closed pull request #2277: FINERACT-1561: Enhancements for APIs
URL: https://github.com/apache/fineract/pull/2277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org