[GitHub] [calcite] jamesstarr commented on a change in pull request #2653: [CALCITE-4952] (Re)introduce a simplistic RelMetadataQuery option

[GitBox <gi...@apache.org>]

jamesstarr commented on a change in pull request #2653:
URL: https://github.com/apache/calcite/pull/2653#discussion_r772700725



##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -3686,4 +4157,71 @@ Sql assertRowsUnique(boolean[] ignoreNulls, Matcher<Boolean> matcher,
     }
 
   }
+
+  /**
+   * A configuration that describes how metadata should be configured.
+   */
+  public static class MetadataConfig {
+
+    private final String name;
+    private final Function<RelMetadataProvider, MetadataHandlerProvider> converter;
+    private final Supplier<RelMetadataProvider> defaultProviderSupplier;
+    private final boolean isCaching;

Review comment:
       Caching is required volcano planner.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org