You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/11/22 01:07:36 UTC

Review Request 64015: Replace node-sass with sass.js

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64015/
-----------------------------------------------------------

Review request for Aurora, Jordan Ly and Kai Huang.


Repository: aurora


Description
-------

Binary dependencies are a bit of a headache for internal corporate firewalls. Turns out there is a pure JS implementation of sass that works with webpack. There is zero discernible difference in build time (in fact a little faster when building from a clean slate).


Diffs
-----

  ui/package.json 634d0f7e3e253a8f7925dbd760d49b43746ea06c 
  ui/src/main/sass/components/_base.scss cf65986ad6bd994498557bc53629373a9ed7f9b8 
  ui/webpack.config.js 363abdd855903feb22da9553563bf31e9ca61bbe 


Diff: https://reviews.apache.org/r/64015/diff/1/


Testing
-------

Built and validated the CSS from a clean Vagrant image.


Thanks,

David McLaughlin

Re: Review Request 64015: Replace node-sass with sass.js

Posted by Jordan Ly <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64015/#review191692
-----------------------------------------------------------


Ship it!




Ship It!

- Jordan Ly


On Nov. 22, 2017, 1:07 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64015/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 1:07 a.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Kai Huang.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Binary dependencies are a bit of a headache for internal corporate firewalls. Turns out there is a pure JS implementation of sass that works with webpack. There is zero discernible difference in build time (in fact a little faster when building from a clean slate).
> 
> 
> Diffs
> -----
> 
>   ui/package.json 634d0f7e3e253a8f7925dbd760d49b43746ea06c 
>   ui/src/main/sass/components/_base.scss cf65986ad6bd994498557bc53629373a9ed7f9b8 
>   ui/webpack.config.js 363abdd855903feb22da9553563bf31e9ca61bbe 
> 
> 
> Diff: https://reviews.apache.org/r/64015/diff/1/
> 
> 
> Testing
> -------
> 
> Built and validated the CSS from a clean Vagrant image.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>