You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Sean Griffin (Jira)" <ji...@apache.org> on 2022/06/14 18:02:00 UTC
[jira] [Commented] (AVRO-3427) Add command line option to skip creation of directories based on namespace path
[ https://issues.apache.org/jira/browse/AVRO-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554230#comment-17554230 ]
Sean Griffin commented on AVRO-3427:
------------------------------------
Curious: was there a reason the --skip-directories option was added when generating code from schema files but not protocol files? I quickly modified the code to pass the "skipDirectoriesCreation" boolean from Program.cs down through to CodeGen.WriteTypes for the GenProtocol flow just like it's done for the GenSchema flow and it appears to work just the same.
> Add command line option to skip creation of directories based on namespace path
> -------------------------------------------------------------------------------
>
> Key: AVRO-3427
> URL: https://issues.apache.org/jira/browse/AVRO-3427
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Paweł Kordowski
> Assignee: Paweł Kordowski
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> In java each part of the namespace is a separate directory but that's not the case for C#.
> In C# you can have directory name that have many namespaces in it.
> For example:
> {noformat}
> Application.Manager.Api{noformat}
> can be a single directory name. In Java it would be 3 separate directories and because of that classes are generated under wrong path. it is placed in:
> {noformat}
> /Application/Manager/Api/{noformat}
> but it should be placed like here:
> {noformat}
> /Application.Manager.Api/{noformat}
> I think the best solution would be to add command line option that would skip creation of directories based on namespace and it would just create classes directly in pointed directory.
>
> Regards,
> Pawel
--
This message was sent by Atlassian Jira
(v8.20.7#820007)