You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wzhfy <gi...@git.apache.org> on 2018/03/20 11:09:55 UTC

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20345#discussion_r175727668
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala ---
    @@ -145,4 +159,15 @@ class JoinOptimizationSuite extends PlanTest {
         }
         assert(broadcastChildren.size == 1)
       }
    +
    +  test("SPARK-23172 skip projections when flattening joins") {
    --- End diff --
    
    Could you add a test case which would fail before the fix?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org