You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Pajaraja (via GitHub)" <gi...@apache.org> on 2025/12/26 17:23:00 UTC

[PR] [MINOR][SQL] Change withTimeZone in Cast to only put it if needed [spark]

Pajaraja opened a new pull request, #53623:
URL: https://github.com/apache/spark/pull/53623

   ### What changes were proposed in this pull request?
   
   Change `withTimeZone` for Cast to only put the time zone if needed for casting.
   
   ### Why are the changes needed?
   
   Analyzer is overeager, so it produces a stronger result (always put time zone for Cast) then needed for Cast to be marked as resolved (only need timezone if it is needed for cast). This causes problems when reanalyzing plan for single-pass analyzer.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   
   ### How was this patch tested?
   
   cte-recursion with single pass, existing CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][SQL] Change withTimeZone in Cast to only put it if needed [spark]

Posted by "Pajaraja (via GitHub)" <gi...@apache.org>.
Pajaraja closed pull request #53623: [MINOR][SQL] Change withTimeZone in Cast to only put it if needed
URL: https://github.com/apache/spark/pull/53623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org