You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/14 14:36:33 UTC
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4783: [IOTDB-2283][IOTDB-2310][IOTDB-2311][IOTDB-2372][IOTDB-2313][IOTDB-2362] GC overhead limit and REST: metadata query interface
SteveYurongSu commented on a change in pull request #4783:
URL: https://github.com/apache/iotdb/pull/4783#discussion_r784892040
##########
File path: server/src/main/java/org/apache/iotdb/db/protocol/rest/handler/RequestValidationHandler.java
##########
@@ -29,6 +29,9 @@ private RequestValidationHandler() {}
public static void validateSQL(SQL sql) {
Objects.requireNonNull(sql.getSql(), "sql should not be null");
+ if (sql.getRowLimit() != null && sql.getRowLimit() <= 0) {
+ Objects.requireNonNull(null, "rowLimit should be greater than or equal to 0");
Review comment:
There are many ways to throw a validation error as a RuntimeException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org